Use a more correct conversion to uint8_t.

ui/gfx/color_utils.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/gfx/color_utils.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <cmath>
@@ skipping 123 matching lines @@
   // If there's no color, we don't care about hue and can do everything based on
   // brightness.
   if (!saturation) {
     uint8_t light;
 
     if (lightness < 0)
       light = 0;
     else if (lightness >= 1.0)
       light = 255;
     else
-      light = static_cast<uint8_t>(SkDoubleToFixed(lightness) >> 8);
+      // Scale from 0 - 255 and round off the value.
+      light = static_cast<uint8_t>(lightness * 255 + .5);

[Peter Kasting, 2016/02/18 23:54:03]

Seems like we could replace this entire conditional with:

    const uint8_t light =
        base::saturated_cast<uint8_t>(gfx::ToRoundedInt(lightness * 255));

[dogben, 2016/02/22 17:30:30]

SGTM, thanks!

 
     return SkColorSetARGB(alpha, light, light, light);
   }
 
   double temp2 = (lightness < 0.5) ?
       (lightness * (1.0 + saturation)) :
       (lightness + saturation - (lightness * saturation));
   double temp1 = 2.0 * lightness - temp2;
   return SkColorSetARGB(alpha, calcHue(temp1, temp2, hue + 1.0 / 3.0),
                         calcHue(temp1, temp2, hue),
@@ skipping 181 matching lines @@
   if (IsDark(text_color)) {
     // For black text, this comes out to kChromeIconGrey.
     return color_utils::AlphaBlend(SK_ColorWHITE, text_color,
                                    SkColorGetR(gfx::kChromeIconGrey));
   }
   // The dimming is less dramatic when darkening a light color.
   return color_utils::AlphaBlend(SK_ColorBLACK, text_color, 0x33);
 }
 
 }  // namespace color_utils