Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1697873003: Revert "Avoid building and archiving the x86-64 pnacl-sz.nexe." (Closed)

Created:
4 years, 10 months ago by Jim Stichnoth
Modified:
4 years, 10 months ago
Reviewers:
Derek Schuff, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert "Avoid building and archiving the x86-64 pnacl-sz.nexe." This reverts commit add84fa7c86ad027cb72ffdbf604a636a004544a. That commit was CL https://codereview.chromium.org/987393003 . Reverting now that pnacl-sz can produce x86-64 nexes. This is needed in particular for measuring the Subzero sandboxed translator on the spec bots. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4077 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/eff184407eb183c8f6ec65d74abc4356d466f448

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M pnacl/build.sh View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Jim Stichnoth
4 years, 10 months ago (2016-02-14 22:56:32 UTC) #3
John
lgtm
4 years, 10 months ago (2016-02-15 00:26:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697873003/1
4 years, 10 months ago (2016-02-15 00:26:59 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: nacl-win32_newlib_opt on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/nacl-win32_newlib_opt/builds/11338)
4 years, 10 months ago (2016-02-15 00:49:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697873003/1
4 years, 10 months ago (2016-02-15 00:49:41 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 01:11:15 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/eff184407...

Powered by Google App Engine
This is Rietveld 408576698