include/core/SkPreConfig.h - Issue 169753004: Enable the SSSE3 files to be built for Android when SSSE3 is not present.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/core/SkPreConfig.h

Issue 169753004: Enable the SSSE3 files to be built for Android when SSSE3 is not present. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/core/SkPreConfig.h

diff --git a/include/core/SkPreConfig.h b/include/core/SkPreConfig.h

index 1c2e24fba6577461abb86244c22a30554d9e38f4..3709c2f9d535351f669b42f52df46f8e71f178a3 100644

--- a/include/core/SkPreConfig.h

+++ b/include/core/SkPreConfig.h

@@ -146,8 +146,10 @@

// Android x86 NDK ABI requires SSE3 support

#if defined(SK_BUILD_FOR_ANDROID)

mtklein 2014/02/21 19:24:31 Same here. Won't we just get this for free becaus

djsollen 2014/02/21 19:38:22 Agreed that we should rely on this. I'll dump the

- #undef SK_CPU_SSE_LEVEL

- #define SK_CPU_SSE_LEVEL SK_CPU_SSE_LEVEL_SSE3

+ #if !defined(SK_CPU_SSE_LEVEL) || (SK_CPU_SSE_LEVEL < SK_CPU_SSE_LEVEL_SSE3)

+ #undef SK_CPU_SSE_LEVEL

+ #define SK_CPU_SSE_LEVEL SK_CPU_SSE_LEVEL_SSE3

reed1 2014/02/21 19:24:29 1. is there no way we can push this off to android

+ #endif

#endif

//////////////////////////////////////////////////////////////////////

« no previous file with comments | « no previous file | src/opts/SkBitmapProcState_opts_SSSE3.cpp » ('j') | src/opts/SkBitmapProcState_opts_SSSE3.cpp » ('J')