Enable the SSSE3 files to be built for Android when SSSE3 is not present.

include/core/SkPreConfig.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkPreConfig_DEFINED
@@ skipping 119 matching lines @@
     #if defined (_M_IX86_FP)
         #if _M_IX86_FP == 1
             #define SK_CPU_SSE_LEVEL    SK_CPU_SSE_LEVEL_SSE1
         #elif _M_IX86_FP >= 2
             #define SK_CPU_SSE_LEVEL    SK_CPU_SSE_LEVEL_SSE2
         #endif
     #endif
 #endif
 
 // 64bit intel guarantees at least SSE2
 #if defined(__x86_64__) || defined(_WIN64)

[mtklein, 2014/02/21 19:24:31]

Shouldn't we be able to just not do these platform checks?  Won't the
GCC/VisualStudio checks above have already set SK_CPU_SSE_LEVEL appropriately?

[djsollen, 2014/02/21 19:38:22]

I'll leave this untouched in the CL, but feel to create another to remove this.

     #if !defined(SK_CPU_SSE_LEVEL) || (SK_CPU_SSE_LEVEL < SK_CPU_SSE_LEVEL_SSE2)
         #undef SK_CPU_SSE_LEVEL
         #define SK_CPU_SSE_LEVEL    SK_CPU_SSE_LEVEL_SSE2
     #endif
 #endif
 
 // Android x86 NDK ABI requires SSE3 support
 #if defined(SK_BUILD_FOR_ANDROID)

[mtklein, 2014/02/21 19:24:31]

Same here.  Won't we just get this for free because we're always going to be
passing -msse3?

[djsollen, 2014/02/21 19:38:22]

Agreed that we should rely on this.  I'll dump the Android version I added.

-    #undef SK_CPU_SSE_LEVEL
-    #define SK_CPU_SSE_LEVEL        SK_CPU_SSE_LEVEL_SSE3
+    #if !defined(SK_CPU_SSE_LEVEL) || (SK_CPU_SSE_LEVEL < SK_CPU_SSE_LEVEL_SSE3)
+        #undef SK_CPU_SSE_LEVEL
+        #define SK_CPU_SSE_LEVEL    SK_CPU_SSE_LEVEL_SSE3

[reed1, 2014/02/21 19:24:29]

1. is there no way we can push this off to android.make, so that our header
doesn't have to know about the latest snapshot of their comstraints?

2. Should this be guarded by building-for-x86? Seems like we're going to define
SK_CPU_SSE_LEVEL on ARM builds...

+    #endif
 #endif
 
 //////////////////////////////////////////////////////////////////////
 // ARM defines
 
 #if defined(__arm__) && (!defined(__APPLE__) || !TARGET_IPHONE_SIMULATOR)
     #define SK_CPU_ARM
 
     #if defined(__GNUC__)
         #if defined(__ARM_ARCH_7__) || defined(__ARM_ARCH_7A__) \
@@ skipping 81 matching lines @@
  *
  * NOTE: Clang/ARM (r161757) does not support the 'optimize' attribute.
  */
 #if SK_HAS_ATTRIBUTE(optimize)
 #   define SK_ATTRIBUTE_OPTIMIZE_O1 __attribute__((optimize("O1")))
 #else
 #   define SK_ATTRIBUTE_OPTIMIZE_O1 /* nothing */
 #endif
 
 #endif