Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 1697183002: Revert of Cleanup: Remove unused PrintSettings shrink factors. (Closed)

Created:
4 years, 10 months ago by phoglund_chromium
Modified:
4 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Cleanup: Remove unused PrintSettings shrink factors. (patchset #1 id:1 of https://codereview.chromium.org/1676953003/ ) Reason for revert: Seems to break printing WebKit Linux MSAN (test times out): https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20MSAN/builds/8511 Original issue's description: > Cleanup: Remove unused PrintSettings shrink factors. > > - They have been unused for 7 years. > - The copy that is being used eventually moved to > third_party/WebKit/Source/core/page/PrintContext.cpp. > > Committed: https://crrev.com/5e8544fc5972711c5237e3bcd8c018a0b439f4f1 > Cr-Commit-Position: refs/heads/master@{#374553} TBR=vitalybuka@chromium.org,tsepez@chromium.org,thestig@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/6101f99726f29e1f2c3def535fe65a48a9b16ee3 Cr-Commit-Position: refs/heads/master@{#375464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M chrome/test/data/printing/cloud_print_uitest.html View 2 chunks +3 lines, -1 line 0 comments Download
M components/printing/browser/print_manager_utils.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/printing/common/print_messages.h View 2 chunks +8 lines, -0 lines 0 comments Download
M components/printing/common/print_messages.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/printing/renderer/print_web_view_helper.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M components/printing/test/mock_printer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/printing/test/mock_printer.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M printing/print_settings.h View 2 chunks +17 lines, -0 lines 0 comments Download
M printing/print_settings.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M printing/print_settings_conversion.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
phoglund_chromium
Created Revert of Cleanup: Remove unused PrintSettings shrink factors.
4 years, 10 months ago (2016-02-15 15:07:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183002/1
4 years, 10 months ago (2016-02-15 15:07:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183002/1
4 years, 10 months ago (2016-02-15 15:32:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183002/1
4 years, 10 months ago (2016-02-15 16:02:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1697183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1697183002/1
4 years, 10 months ago (2016-02-15 16:33:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-15 16:44:42 UTC) #6
phoglund_chromium
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1701703003/ by phoglund@chromium.org. ...
4 years, 10 months ago (2016-02-16 10:07:28 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:50:12 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6101f99726f29e1f2c3def535fe65a48a9b16ee3
Cr-Commit-Position: refs/heads/master@{#375464}

Powered by Google App Engine
This is Rietveld 408576698