components/printing/renderer/print_web_view_helper.cc - Issue 1697183002: Revert of Cleanup: Remove unused PrintSettings shrink factors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/printing/renderer/print_web_view_helper.cc

Issue 1697183002: Revert of Cleanup: Remove unused PrintSettings shrink factors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/printing/renderer/print_web_view_helper.cc

diff --git a/components/printing/renderer/print_web_view_helper.cc b/components/printing/renderer/print_web_view_helper.cc

index bbb018922b5eccf4a04af7029cd447ee32ee8e7c..991105448bb6ac3bea46a6f7a63c1dbbd3bd738a 100644

--- a/components/printing/renderer/print_web_view_helper.cc

+++ b/components/printing/renderer/print_web_view_helper.cc

@@ -111,9 +111,9 @@

bool PrintMsg_Print_Params_IsValid(const PrintMsg_Print_Params& params) {

return !params.content_size.IsEmpty() && !params.page_size.IsEmpty() &&

!params.printable_area.IsEmpty() && params.document_cookie &&

- params.desired_dpi && params.dpi && params.margin_top >= 0 &&

- params.margin_left >= 0 && params.dpi > kMinDpi &&

- params.document_cookie != 0;

+ params.desired_dpi && params.max_shrink && params.min_shrink &&

+ params.dpi && (params.margin_top >= 0) && (params.margin_left >= 0) &&

+ params.dpi > kMinDpi && params.document_cookie != 0;

}

PrintMsg_Print_Params GetCssPrintParams(

« no previous file with comments | « components/printing/common/print_messages.cc ('k') | components/printing/test/mock_printer.h » ('j') | no next file with comments »