Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 169713003: Remove WindowState::IsNormalShowState() (Closed)

Created:
6 years, 10 months ago by pkotwicz
Modified:
6 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, kalyank, sadrul, dcheng, ben+ash_chromium.org
Visibility:
Public.

Description

Remove WindowState::IsNormalShowState() BUG=326392 TEST=None R=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253171

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -78 lines) Patch
M ash/accelerators/accelerator_commands_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/root_window_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/caption_buttons/alternate_frame_size_button_unittest.cc View 1 2 3 chunks +4 lines, -8 lines 0 comments Download
M ash/wm/caption_buttons/frame_maximize_button_unittest.cc View 1 2 10 chunks +9 lines, -18 lines 0 comments Download
M ash/wm/default_state.cc View 1 2 4 chunks +4 lines, -5 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ash/wm/dock/docked_window_resizer.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/drag_details.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ash/wm/resize_shadow_and_cursor_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/window_state.h View 1 1 chunk +3 lines, -8 lines 0 comments Download
M ash/wm/window_state.cc View 1 3 chunks +7 lines, -8 lines 0 comments Download
M ash/wm/window_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/snap_sizer_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/ash/accelerator_commands_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (0 generated)
pkotwicz
Oshima, can you please take a look?
6 years, 10 months ago (2014-02-18 04:47:59 UTC) #1
oshima
lgtm
6 years, 10 months ago (2014-02-19 18:29:50 UTC) #2
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 04:08:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169713003/90001
6 years, 10 months ago (2014-02-22 04:09:02 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 05:09:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_x64_rel for step(s) base_unittests, chrome_elf_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_rel&number=78310
6 years, 10 months ago (2014-02-22 05:09:12 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 17:01:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169713003/90001
6 years, 10 months ago (2014-02-22 17:01:47 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-22 18:45:28 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=268521
6 years, 10 months ago (2014-02-22 18:45:28 UTC) #10
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 18:56:52 UTC) #11
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 18:57:08 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169713003/90001
6 years, 10 months ago (2014-02-22 18:57:17 UTC) #13
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 21:38:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/169713003/90001
6 years, 10 months ago (2014-02-22 21:38:09 UTC) #15
pkotwicz
The CQ bit was unchecked by pkotwicz@chromium.org
6 years, 10 months ago (2014-02-22 23:17:53 UTC) #16
pkotwicz
6 years, 9 months ago (2014-02-25 15:33:50 UTC) #17
Message was sent while issue was closed. 
Committed patchset #3 manually as r253171 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698