Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2718)

Unified Diff: ash/wm/window_state.cc

Issue 169713003: Remove WindowState::IsNormalShowState() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/wm/window_state.h ('k') | ash/wm/window_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/wm/window_state.cc
diff --git a/ash/wm/window_state.cc b/ash/wm/window_state.cc
index 4f5c1569092bd13dd351eb680283e2e9d75b5a32..a9116b1db19eb78474a33114471db8e3e6ceeef7 100644
--- a/ash/wm/window_state.cc
+++ b/ash/wm/window_state.cc
@@ -140,9 +140,9 @@ bool WindowState::IsMaximizedOrFullscreen() const {
show_state == ui::SHOW_STATE_MAXIMIZED;
}
-bool WindowState::IsNormalShowState() const {
- ui::WindowShowState state = GetShowState();
- return state == ui::SHOW_STATE_NORMAL || state == ui::SHOW_STATE_DEFAULT;
+bool WindowState::IsSnapped() const {
+ return window_show_type_ == SHOW_TYPE_LEFT_SNAPPED ||
+ window_show_type_ == SHOW_TYPE_RIGHT_SNAPPED;
}
bool WindowState::IsNormalShowType() const {
@@ -150,6 +150,10 @@ bool WindowState::IsNormalShowType() const {
window_show_type_ == SHOW_TYPE_DEFAULT;
}
+bool WindowState::IsNormalOrSnapped() const {
+ return IsNormalShowType() || IsSnapped();
+}
+
bool WindowState::IsActive() const {
return IsActiveWindow(window_);
}
@@ -159,11 +163,6 @@ bool WindowState::IsDocked() const {
window_->parent()->id() == internal::kShellWindowId_DockedContainer;
}
-bool WindowState::IsSnapped() const {
- return window_show_type_ == SHOW_TYPE_LEFT_SNAPPED ||
- window_show_type_ == SHOW_TYPE_RIGHT_SNAPPED;
-}
-
bool WindowState::CanMaximize() const {
return window_->GetProperty(aura::client::kCanMaximizeKey);
}
« no previous file with comments | « ash/wm/window_state.h ('k') | ash/wm/window_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698