Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 1696713003: Introduce maxColumnLogicalHeight() and clean up a little. (Closed)

Created:
4 years, 10 months ago by mstensho (USE GERRIT)
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce maxColumnLogicalHeight() and clean up a little. Looks like MultiColumnFragmentainerGroup::calculateMaxColumnHeight() isn't going to be the only place where we need this functionality. No functional changes intended. R=leviw@chromium.org Committed: https://crrev.com/1a8e73e16131664aae15e07536df7fc42e0d0542 Cr-Commit-Position: refs/heads/master@{#376075}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.h View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 1 chunk +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/MultiColumnFragmentainerGroup.cpp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mstensho (USE GERRIT)
4 years, 10 months ago (2016-02-12 13:35:50 UTC) #1
leviw_travelin_and_unemployed
lgtm
4 years, 10 months ago (2016-02-18 00:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1696713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1696713003/1
4 years, 10 months ago (2016-02-18 00:49:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 02:41:30 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 02:42:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a8e73e16131664aae15e07536df7fc42e0d0542
Cr-Commit-Position: refs/heads/master@{#376075}

Powered by Google App Engine
This is Rietveld 408576698