Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp

Issue 1696713003: Introduce maxColumnLogicalHeight() and clean up a little. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 257 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 multicolContainer->resetMultiColumnFlowThread(); 268 multicolContainer->resetMultiColumnFlowThread();
269 moveAllChildrenTo(multicolContainer, true); 269 moveAllChildrenTo(multicolContainer, true);
270 270
271 // We used to manually nuke the line box tree here, but that should happen a utomatically when 271 // We used to manually nuke the line box tree here, but that should happen a utomatically when
272 // moving children around (the code above). 272 // moving children around (the code above).
273 ASSERT(!firstLineBox()); 273 ASSERT(!firstLineBox());
274 274
275 destroy(); 275 destroy();
276 } 276 }
277 277
278 LayoutUnit LayoutMultiColumnFlowThread::maxColumnLogicalHeight() const
279 {
280 if (m_columnHeightAvailable) {
281 // If height is non-auto, it's already constrained against max-height as well.
282 // Just return it.
283 return m_columnHeightAvailable;
284 }
285 const LayoutBlockFlow* multicolBlock = multiColumnBlockFlow();
286 Length logicalMaxHeight = multicolBlock->style()->logicalMaxHeight();
287 if (!logicalMaxHeight.isMaxSizeNone()) {
288 LayoutUnit resolvedLogicalMaxHeight = multicolBlock->computeContentLogic alHeight(MaxSize, logicalMaxHeight, -1);
289 if (resolvedLogicalMaxHeight != -1)
290 return resolvedLogicalMaxHeight;
291 }
292 return LayoutUnit::max();
293 }
294
278 LayoutUnit LayoutMultiColumnFlowThread::tallestUnbreakableLogicalHeight(LayoutUn it offsetInFlowThread) const 295 LayoutUnit LayoutMultiColumnFlowThread::tallestUnbreakableLogicalHeight(LayoutUn it offsetInFlowThread) const
279 { 296 {
280 if (LayoutMultiColumnSet* multicolSet = columnSetAtBlockOffset(offsetInFlowT hread)) 297 if (LayoutMultiColumnSet* multicolSet = columnSetAtBlockOffset(offsetInFlowT hread))
281 return multicolSet->tallestUnbreakableLogicalHeight(); 298 return multicolSet->tallestUnbreakableLogicalHeight();
282 return LayoutUnit(); 299 return LayoutUnit();
283 } 300 }
284 301
285 LayoutSize LayoutMultiColumnFlowThread::columnOffset(const LayoutPoint& point) c onst 302 LayoutSize LayoutMultiColumnFlowThread::columnOffset(const LayoutPoint& point) c onst
286 { 303 {
287 if (!hasValidColumnSetInfo()) 304 if (!hasValidColumnSetInfo())
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
958 } 975 }
959 if (canContainSpannerInParentFragmentationContext(*object)) 976 if (canContainSpannerInParentFragmentationContext(*object))
960 next = object->nextInPreOrder(&root); 977 next = object->nextInPreOrder(&root);
961 else 978 else
962 next = object->nextInPreOrderAfterChildren(&root); 979 next = object->nextInPreOrderAfterChildren(&root);
963 } 980 }
964 return true; 981 return true;
965 } 982 }
966 983
967 } // namespace blink 984 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698