Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: chromeos/dbus/debug_daemon_client.cc

Issue 16966003: Rewrite scoped_ptr<T>(NULL) to use the default ctor in chromeos/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/debug_daemon_client.cc
diff --git a/chromeos/dbus/debug_daemon_client.cc b/chromeos/dbus/debug_daemon_client.cc
index 29c5b1c3d24102bd7476a5f7402226f502515d3b..19ebd279194977d90eacb0662e075940a93653f5 100644
--- a/chromeos/dbus/debug_daemon_client.cc
+++ b/chromeos/dbus/debug_daemon_client.cc
@@ -44,8 +44,7 @@ class PipeReader {
typedef base::Callback<void(void)>IOCompleteCallback;
explicit PipeReader(IOCompleteCallback callback)
- : data_stream_(NULL),
- io_buffer_(new net::IOBufferWithSize(4096)),
+ : io_buffer_(new net::IOBufferWithSize(4096)),
callback_(callback),
weak_ptr_factory_(this) {
pipe_fd_[0] = pipe_fd_[1] = -1;
@@ -142,9 +141,7 @@ namespace chromeos {
class DebugDaemonClientImpl : public DebugDaemonClient {
public:
explicit DebugDaemonClientImpl(dbus::Bus* bus)
- : debugdaemon_proxy_(NULL),
- pipe_reader_(NULL),
- weak_ptr_factory_(this) {
+ : debugdaemon_proxy_(NULL), weak_ptr_factory_(this) {
Daniel Erat 2013/06/13 15:46:33 nit: i believe that these should remain on separat
dcheng 2013/06/13 15:48:11 This is the result from clang-format-diff. If you
Daniel Erat 2013/06/13 15:49:44 thanks, please do so. i think that clang-format-di
dcheng 2013/06/13 18:49:20 Done. However, a literal reading suggests that th
debugdaemon_proxy_ = bus->GetObjectProxy(
debugd::kDebugdServiceName,
dbus::ObjectPath(debugd::kDebugdServicePath));
« no previous file with comments | « no previous file | chromeos/dbus/ibus/ibus_object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698