Rewrite scoped_ptr<T>(NULL) to use the default ctor in chromeos/.

chromeos/dbus/debug_daemon_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <fcntl.h>
 #include <unistd.h>
 
 #include "chromeos/dbus/debug_daemon_client.h"
 
 #include "base/bind.h"
@@ skipping 26 matching lines @@
 // the instance on callback.  The data should be retrieved before
 // delete and extracted or copied.
 //
 // TODO(sleffler) move data collection to a sub-class so this
 // can be reused to process data as it is received
 class PipeReader {
  public:
   typedef base::Callback<void(void)>IOCompleteCallback;
 
   explicit PipeReader(IOCompleteCallback callback)
-      : data_stream_(NULL),
-        io_buffer_(new net::IOBufferWithSize(4096)),
+      : io_buffer_(new net::IOBufferWithSize(4096)),
         callback_(callback),
         weak_ptr_factory_(this) {
     pipe_fd_[0] = pipe_fd_[1] = -1;
   }
 
   virtual ~PipeReader() {
     // Don't close pipe_fd_[0] as it's closed by data_stream_.
     if (pipe_fd_[1] != -1)
       if (HANDLE_EINTR(close(pipe_fd_[1])) < 0)
         PLOG(ERROR) << "close[1]";
@@ skipping 76 matching lines @@
 };
 
 }  // namespace
 
 namespace chromeos {
 
 // The DebugDaemonClient implementation used in production.
 class DebugDaemonClientImpl : public DebugDaemonClient {
  public:
   explicit DebugDaemonClientImpl(dbus::Bus* bus)
-      : debugdaemon_proxy_(NULL),
-        pipe_reader_(NULL),
-        weak_ptr_factory_(this) {
+      : debugdaemon_proxy_(NULL), weak_ptr_factory_(this) {

[Daniel Erat, 2013/06/13 15:46:33]

nit: i believe that these should remain on separate lines since they don't fit
on the same line as the c'tor's signature

[dcheng, 2013/06/13 15:48:11]

This is the result from clang-format-diff. If you prefer, I can manually revert
this.

[Daniel Erat, 2013/06/13 15:49:44]

thanks, please do so. i think that clang-format-diff conflicts with the style
guide here -- see
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...

[dcheng, 2013/06/13 18:49:20]

Done.

However, a literal reading suggests that this is, in fact, permissible.
"Constructor initializer lists can be all on one line"
DebugDaemonClientImpl(dbus::Bus* bus) is not part of the initializer list, thus
the initializer list is still on one line.

Indirectly, further support for this can be found in
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Constr...;
there, it explicitly states that parameters should be on the same line if they
fit.

     debugdaemon_proxy_ = bus->GetObjectProxy(
         debugd::kDebugdServiceName,
         dbus::ObjectPath(debugd::kDebugdServicePath));
   }
 
   virtual ~DebugDaemonClientImpl() {}
 
   // DebugDaemonClient override.
   virtual void GetDebugLogs(base::PlatformFile file,
                             const GetDebugLogsCallback& callback) OVERRIDE {
@@ skipping 476 matching lines @@
 // static
 DebugDaemonClient* DebugDaemonClient::Create(DBusClientImplementationType type,
                                    dbus::Bus* bus) {
   if (type == REAL_DBUS_CLIENT_IMPLEMENTATION)
     return new DebugDaemonClientImpl(bus);
   DCHECK_EQ(STUB_DBUS_CLIENT_IMPLEMENTATION, type);
   return new DebugDaemonClientStubImpl();
 }
 
 }  // namespace chromeos