Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2721)

Unified Diff: blimp/client/app/blimp_client_switches.h

Issue 1696563002: Blimp: add support for SSL connections. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/app/blimp_client_switches.h
diff --git a/blimp/client/app/blimp_client_switches.h b/blimp/client/app/blimp_client_switches.h
index 88167f104ef3f9b5f9e44fbaf49315372e760d24..b93a39bb0e0518fd8a1fe8ddb3e505261b805d7e 100644
--- a/blimp/client/app/blimp_client_switches.h
+++ b/blimp/client/app/blimp_client_switches.h
@@ -10,9 +10,26 @@
namespace blimp {
namespace switches {
+// The path to the Blimplet's PEM-encoded X509 certificate.
+// If specified, SSL connected Blimplets must supply this certificate
+// for the connection to be valid.
+// e.g.:
+// --blimplet-cert-path=/home/blimp/certs/cert.pem
Wez 2016/02/12 02:31:13 Presumably this must only be specified in conjunct
Kevin M 2016/02/13 00:44:17 This is consistent with the engine's use of a "-pa
+extern const char kBlimpletCertPath[];
+
+// Specifies the blimplet IP-address to connect to, e.g.:
+// --blimplet-host="127.0.0.1".
+// TODO(nyquist): Add support for DNS-lookup. See http://crbug.com/576857.
extern const char kBlimpletHost[];
+
+// Specifies the blimplet TCP (unencrypted) port to connect to, e.g.:
+// --blimplet-tcp-port=25467.
extern const char kBlimpletTCPPort[];
+// Specifies the blimplet TCP (unencrypted) port to connect to, e.g.:
+// --blimplet-ssl-port=25466.
Wez 2016/02/12 02:31:13 typo: encrypted
Kevin M 2016/02/13 00:44:17 Done.
+extern const char kBlimpletSSLPort[];
Wez 2016/02/12 02:31:12 Could we instead have a --engine-url parameter of
Kevin M 2016/02/13 00:44:17 Would adding support for URLs imply that we should
+
} // namespace switches
} // namespace blimp

Powered by Google App Engine
This is Rietveld 408576698