Blimp: add support for SSL connections.

blimp/client/app/blimp_client_switches.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Defines all the command-line switches used by //blimp.
 
 #ifndef BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_
 #define BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_
 
 namespace blimp {
 namespace switches {
 
+// The path to the Blimplet's PEM-encoded X509 certificate.
+// If specified, SSL connected Blimplets must supply this certificate
+// for the connection to be valid.
+// e.g.:
+// --blimplet-cert-path=/home/blimp/certs/cert.pem

[Wez, 2016/02/12 02:31:13]

Presumably this must only be specified in conjunction w/ the
--blimplet-ssl-port?

Can we rename this --engine-cert-path or just --engine-cert?

[Kevin M, 2016/02/13 00:44:17]

This is consistent with the engine's use of a "-path" suffix to denote
parameters that indirectly supply values via filepaths.

+extern const char kBlimpletCertPath[];
+
+// Specifies the blimplet IP-address to connect to, e.g.:
+// --blimplet-host="127.0.0.1".
+// TODO(nyquist): Add support for DNS-lookup. See http://crbug.com/576857.
 extern const char kBlimpletHost[];
+
+// Specifies the blimplet TCP (unencrypted) port to connect to, e.g.:
+// --blimplet-tcp-port=25467.
 extern const char kBlimpletTCPPort[];
 
+// Specifies the blimplet TCP (unencrypted) port to connect to, e.g.:
+// --blimplet-ssl-port=25466.

[Wez, 2016/02/12 02:31:13]

typo: encrypted

[Kevin M, 2016/02/13 00:44:17]

Done.

+extern const char kBlimpletSSLPort[];

[Wez, 2016/02/12 02:31:12]

Could we instead have a --engine-url parameter of the form
scheme://<host>:<port> rather than have all these parameters?

Or could we have a single parameter --test-mode which causes any subsequent
parameters on the command-line to be treated as host, port and cert-file?

(Having so many verbose-named parameters seems overkill and not very convenient
for development/testing)

[Kevin M, 2016/02/13 00:44:17]

Would adding support for URLs imply that we should also support hostname
resolution, though?

+
 }  // namespace switches
 }  // namespace blimp
 
 #endif  // BLIMP_CLIENT_APP_BLIMP_CLIENT_SWITCHES_H_