src/full-codegen/mips/full-codegen-mips.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge problems Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/mips/full-codegen-mips.cc

diff --git a/src/full-codegen/mips/full-codegen-mips.cc b/src/full-codegen/mips/full-codegen-mips.cc

index 5a3512224d21d2a14f55e4f86e182d60087f484c..be58a157990d0f9f66ad00fa5856878e53ac0421 100644

--- a/src/full-codegen/mips/full-codegen-mips.cc

+++ b/src/full-codegen/mips/full-codegen-mips.cc

@@ -1933,9 +1933,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator,

// fp = caller's frame pointer.

// cp = callee's context,

// t0 = callee's JS function.

- __ Push(ra, fp, cp, t0);

- // Adjust FP to point to saved FP.

- __ Addu(fp, sp, 2 * kPointerSize);

+ __ PushStandardFrame(t0);

// Load the operand stack size.

__ lw(a3, FieldMemOperand(a1, JSGeneratorObject::kOperandStackOffset));