src/full-codegen/arm/full-codegen-arm.cc - Issue 1696043002: [runtime] Unify and simplify how frames are marked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1696043002: [runtime] Unify and simplify how frames are marked (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix merge problems Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/arm/full-codegen-arm.cc

diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc

index 1ff706cab8b5af80c02d6d81ea88853a546c2dc2..1235ad3d4c56f4ec37b0e961c9d8fc5ad50ea5c7 100644

--- a/src/full-codegen/arm/full-codegen-arm.cc

+++ b/src/full-codegen/arm/full-codegen-arm.cc

@@ -1939,9 +1939,7 @@ void FullCodeGenerator::EmitGeneratorResume(Expression *generator,

// pp = caller's constant pool (if FLAG_enable_embedded_constant_pool),

// cp = callee's context,

// r4 = callee's JS function.

- __ PushFixedFrame(r4);

- // Adjust FP to point to saved FP.

- __ add(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

+ __ PushStandardFrame(r4);

// Load the operand stack size.

__ ldr(r3, FieldMemOperand(r1, JSGeneratorObject::kOperandStackOffset));