[CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

[CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}

The rename happened two drafts ago so it's likely safe to rename it now in the
code as it seems this is likely the final name of the properties.

BUG=252106
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=153170

[svillar, 2013-06-19 12:34:18]

Should I also update the ietestcenter/css3/grid tests?

[Julien - ping for review, 2013-06-19 22:28:00]

On 2013/06/19 12:34:18, svillar wrote:
> Should I also update the ietestcenter/css3/grid tests?

Yes or else we would not be able to pass them if it makes sense.

Btw, you are right that there is no explicit bug about that so you may want to
open a new one or just have this change blocks bug 79180 (CSS Grid Layout meta
bug).

[Julien - ping for review, 2013-06-19 22:28:25]

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
File
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt
(right):

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:5:
(rect 8 48 250 50)
This change looks wrong: the repaint rectangles shouldn't change as part of this
change.

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
File
LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt
(right):

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
LayoutTests/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt:5:
(rect 8 48 100 150)
Same comments about the repaint rectangles.

https://codereview.chromium.org/16959008/diff/3001/Source/core/css/CSSPropert...
File Source/core/css/CSSProperty.cpp (right):

https://codereview.chromium.org/16959008/diff/3001/Source/core/css/CSSPropert...
Source/core/css/CSSProperty.cpp:586: case CSSPropertyGridDefinitionRows:
Let's keep this list ordered :)

[svillar, 2013-06-20 07:17:56]

Will add the ITC changes

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
File
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt
(right):

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:5:
(rect 8 48 250 50)
On 2013/06/19 22:28:25, Julien Chaffraix wrote:
> This change looks wrong: the repaint rectangles shouldn't change as part of
this
> change.

That's what I thought but the fact is that the Y value changes because the size
of the paragraph above changes. We might decide not to change the comment in the
bug but I think it's safe.

https://codereview.chromium.org/16959008/diff/3001/Source/core/css/CSSPropert...
File Source/core/css/CSSProperty.cpp (right):

https://codereview.chromium.org/16959008/diff/3001/Source/core/css/CSSPropert...
Source/core/css/CSSProperty.cpp:586: case CSSPropertyGridDefinitionRows:
On 2013/06/19 22:28:25, Julien Chaffraix wrote:
> Let's keep this list ordered :)

Oh sure.

[Julien - ping for review, 2013-06-21 21:08:40]

I would like to see the ITC changes but it looks really nice. Thanks!

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
File
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt
(right):

https://codereview.chromium.org/16959008/diff/3001/LayoutTests/fast/css-grid-...
LayoutTests/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt:5:
(rect 8 48 250 50)
On 2013/06/20 07:17:56, svillar wrote:
> On 2013/06/19 22:28:25, Julien Chaffraix wrote:
> > This change looks wrong: the repaint rectangles shouldn't change as part of
> this
> > change.
> 
> That's what I thought but the fact is that the Y value changes because the
size
> of the paragraph above changes. We might decide not to change the comment in
the
> bug but I think it's safe.

You are right, we set the font size to 10 in this test so it looks like we have
an extra line of text before of the longer property names. I would still go
ahead with the renaming of this test as we understand the difference.

[svillar, 2013-06-25 08:08:16]

On 2013/06/21 21:08:40, Julien Chaffraix wrote:
> I would like to see the ITC changes but it looks really nice. Thanks!

Hmm what do you mean? I have already included them in the latest patch set.
Anything else you'd want me to change?

[Julien - ping for review, 2013-06-25 16:37:34]

>> I would like to see the ITC changes but it looks really nice. Thanks!

> Hmm what do you mean? I have already included them in the latest patch set.
> Anything else you'd want me to change?

Mhh, I swear the ITC bits weren't there when I commented. LGTM but I would make
sure Tab confirms that these properties won't change their name following the
F2F earlier this month.

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
File LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm (right):

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm:57:
grid-definition-rows: auto 1fr;
We probably should rename all of these (I didn't repeat this comment to the
other ITC files).

[svillar, 2013-06-26 11:06:40]

On 2013/06/25 16:37:34, Julien Chaffraix wrote:
> >> I would like to see the ITC changes but it looks really nice. Thanks!
> 
> > Hmm what do you mean? I have already included them in the latest patch set.
> > Anything else you'd want me to change?
> 
> Mhh, I swear the ITC bits weren't there when I commented. LGTM but I would
make
> sure Tab confirms that these properties won't change their name following the
> F2F earlier this month.

There is a conf call today and it seems that it isn't in the agenda but yeah we
could double-check with Tab.

[svillar, 2013-06-26 11:06:58]

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
File LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm (right):

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm:57:
grid-definition-rows: auto 1fr;
On 2013/06/25 16:37:34, Julien Chaffraix wrote:
> We probably should rename all of these (I didn't repeat this comment to the
> other ITC files).

You mean the other vendor prefixed versions?

[Julien - ping for review, 2013-06-26 18:17:07]

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
File LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm (right):

https://codereview.chromium.org/16959008/diff/17001/LayoutTests/ietestcenter/...
LayoutTests/ietestcenter/css3/grid/grid-items-005-expected.htm:57:
grid-definition-rows: auto 1fr;
On 2013/06/26 11:06:58, svillar wrote:
> On 2013/06/25 16:37:34, Julien Chaffraix wrote:
> > We probably should rename all of these (I didn't repeat this comment to the
> > other ITC files).
> 
> You mean the other vendor prefixed versions?

Yes.

[Julien - ping for review, 2013-06-27 18:02:50]

lgtm

[commit-bot: I haz the power, 2013-06-27 18:02:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/svillar@igalia.com/16959008/33001

[commit-bot: I haz the power, 2013-06-27 20:14:07]

Change committed as 153170