1This test checks that changing the grid-columns lead to a repaint. The final grid element should be 250px * 50px, the grid item should be 50px * 50px. No trace of the elements before the grid-columns change should be seen.
1This test checks that changing the grid-definition-columns lead to a repaint. The final grid element should be 250px * 50px, the grid item should be 50px * 50px. No trace of the elements before the grid-definition-columns change should be seen.
2 (repaint rects
2 (repaint rects
3 (rect 8 38 100 50)
3 (rect 8 48 100 50)
4 (rect 8 38 50 50)
4 (rect 8 48 50 50)
5 (rect 8 38 250 50)
5 (rect 8 48 250 50)
Julien - ping for review
2013/06/19 22:28:25
This change looks wrong: the repaint rectangles sh
This change looks wrong: the repaint rectangles shouldn't change as part of this
change.
svillar
2013/06/20 07:17:56
That's what I thought but the fact is that the Y v
On 2013/06/19 22:28:25, Julien Chaffraix wrote:
> This change looks wrong: the repaint rectangles shouldn't change as part of
this
> change.
That's what I thought but the fact is that the Y value changes because the size
of the paragraph above changes. We might decide not to change the comment in the
bug but I think it's safe.
Julien - ping for review
2013/06/21 21:08:40
You are right, we set the font size to 10 in this
On 2013/06/20 07:17:56, svillar wrote:
> On 2013/06/19 22:28:25, Julien Chaffraix wrote:
> > This change looks wrong: the repaint rectangles shouldn't change as part of
> this
> > change.
>
> That's what I thought but the fact is that the Y value changes because the
size
> of the paragraph above changes. We might decide not to change the comment in
the
> bug but I think it's safe.
You are right, we set the font size to 10 in this test so it looks like we have
an extra line of text before of the longer property names. I would still go
ahead with the renaming of this test as we understand the difference.
Issue 16959008: [CSS Grid Layout] Rename grid-{rows|columns} to grid-definition-{rows|columns}
(Closed)
Created 7 years, 6 months ago by svillar
Modified 7 years, 5 months ago
Reviewers: Julien - ping for review, TabAtkins
Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Comments: 9