[NaCl SDK] httpfs now sets errno to an appropriate value on non-200 response.

[NaCl SDK] httpfs now sets errno to an appropriate value on non-200 response.

BUG=251662
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=207461

[Matt Giuca, 2013-06-19 10:10:20]

Hi Ben,

Here is another misc code review for you.

A very strange thing about the tests: I thought I was going to run into
http://crbug.com/244313, but I didn't. Even though my tests are almost identical
to OpenAndCloseNoCache, mine pass, whereas that test (and another) call Create
too many times. I don't understand, but that's not relevant to this CL anyhow.

[binji, 2013-06-19 15:53:19]

lgtm, thanks!

(I've been meaning to look into those test failures. I haven't been too
concerned because I think they are errors in the test, not in the code. Too much
other stuff first, unfortunately).

[Matt Giuca, 2013-06-20 00:15:42]

Thanks.

Hope you don't mind: I made a small post-lgtm change to avoid checking for a
good status twice. I think it's cleaner this way.

[commit-bot: I haz the power, 2013-06-20 01:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/16959007/1003

[commit-bot: I haz the power, 2013-06-20 02:06:26]

Step "update" is always a major failure.
Look at the try server FAQ for more details.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura...

[commit-bot: I haz the power, 2013-06-20 09:40:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mgiuca@chromium.org/16959007/1003

[commit-bot: I haz the power, 2013-06-20 17:03:43]

Change committed as 207461