[NaCl SDK] httpfs now sets errno to an appropriate value on non-200 response.

native_client_sdk/src/libraries/nacl_io/mount_node_http.cc

 /* Copyright (c) 2013 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "nacl_io/mount_node_http.h"
 
 #include <assert.h>
 #include <errno.h>
 #include <stdio.h>
 #include <string.h>
 
 #include <ppapi/c/pp_errors.h>
 
 #include "nacl_io/mount_http.h"
 #include "nacl_io/osinttypes.h"
 
 #if defined(WIN32)
 #define snprintf _snprintf
 #endif
 
 namespace {
 
 // If we're attempting to read a partial request, but the server returns a full
 // request, we need to read all of the data up to the start of our partial
 // request into a dummy buffer. This is the maximum size of that buffer.
 const size_t MAX_READ_BUFFER_SIZE = 64 * 1024;
 const int32_t STATUSCODE_OK = 200;
 const int32_t STATUSCODE_PARTIAL_CONTENT = 206;
+const int32_t STATUSCODE_FORBIDDEN = 403;
+const int32_t STATUSCODE_NOT_FOUND = 404;
 
 StringMap_t ParseHeaders(const char* headers, int32_t headers_length) {
   enum State {
     FINDING_KEY,
     SKIPPING_WHITESPACE,
     FINDING_VALUE,
   };
 
   StringMap_t result;
   std::string key;
@@ skipping 77 matching lines @@
   } else if (result == 3) {
     *read_start = read_start_int;
     *read_end = read_end_int + 1;
     *entity_length = entity_length_int;
     return true;
   }
 
   return false;
 }
 
+// Maps an HTTP |status_code| onto the appropriate errno code.
+int HTTPStatusCodeToErrno(int status_code) {
+  switch (status_code) {
+    case STATUSCODE_OK:
+    case STATUSCODE_PARTIAL_CONTENT:
+      return 0;
+    case STATUSCODE_FORBIDDEN:
+      return EACCES;
+    case STATUSCODE_NOT_FOUND:
+      return ENOENT;
+  }
+  if (status_code >= 400 && status_code < 500)
+    return EINVAL;
+  return EIO;
+}
+
 }  // namespace
 
 void MountNodeHttp::SetCachedSize(off_t size) {
   has_cached_size_ = true;
   stat_.st_size = size;
 }
 
 Error MountNodeHttp::FSync() { return ENOSYS; }
 
 Error MountNodeHttp::GetDents(size_t offs,
@@ skipping 154 matching lines @@
   // Get response statuscode.
   PP_Var statuscode = response_interface->GetProperty(
       response.pp_resource(), PP_URLRESPONSEPROPERTY_STATUSCODE);
 
   if (statuscode.type != PP_VARTYPE_INT32)
     return EINVAL;
 
   *out_statuscode = statuscode.value.as_int;
 
   // Only accept OK or Partial Content.
-  if (*out_statuscode != STATUSCODE_OK &&
-      *out_statuscode != STATUSCODE_PARTIAL_CONTENT) {
-    return EINVAL;
-  }
+  Error error = HTTPStatusCodeToErrno(*out_statuscode);
+  if (error)
+    return error;
 
   // Get response headers.
   PP_Var response_headers_var = response_interface->GetProperty(
       response.pp_resource(), PP_URLRESPONSEPROPERTY_HEADERS);
 
   uint32_t response_headers_length;
   const char* response_headers_str =
       var_interface->VarToUtf8(response_headers_var, &response_headers_length);
 
   *out_loader = loader.Release();
@@ skipping 199 matching lines @@
       return PPErrorToErrno(bytes_read);
 
     assert(bytes_read <= bytes_to_read);
     bytes_to_read -= bytes_read;
     out_buffer += bytes_read;
   }
 
   *out_bytes = count;
   return 0;
 }