Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1695663002: Unflake SampleWhenFrameIsNotSetup (Closed)

Created:
4 years, 10 months ago by alph
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, ulan, yurys
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unflake SampleWhenFrameIsNotSetup Recent flake happened bacause all the samples landed into native code. The patch makes sure we collect enough JS samples. BUG=v8:4751 LOG=N Committed: https://crrev.com/14a1dec8d0fbc722a38e5fa00f8aab5c77745448 Cr-Commit-Position: refs/heads/master@{#33953}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -24 lines) Patch
M src/profiler/sampler.h View 2 chunks +8 lines, -7 lines 0 comments Download
M src/profiler/sampler.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 9 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695663002/1
4 years, 10 months ago (2016-02-12 03:05:13 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-12 03:42:07 UTC) #4
alph
4 years, 10 months ago (2016-02-12 04:09:07 UTC) #6
ulan
lgtm
4 years, 10 months ago (2016-02-12 11:58:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695663002/1
4 years, 10 months ago (2016-02-12 16:01:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-12 16:02:36 UTC) #12
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 16:02:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/14a1dec8d0fbc722a38e5fa00f8aab5c77745448
Cr-Commit-Position: refs/heads/master@{#33953}

Powered by Google App Engine
This is Rietveld 408576698