Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1065)

Unified Diff: src/profiler/sampler.h

Issue 1695663002: Unflake SampleWhenFrameIsNotSetup (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/profiler/sampler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/sampler.h
diff --git a/src/profiler/sampler.h b/src/profiler/sampler.h
index 282b5b958b74949f9b411c78f0c5ef4e23d6c216..d890f71c258aa5c8b70a970aa0de74aa70e752b2 100644
--- a/src/profiler/sampler.h
+++ b/src/profiler/sampler.h
@@ -100,12 +100,12 @@ class Sampler {
}
// Used in tests to make sure that stack sampling is performed.
- unsigned js_and_external_sample_count() const {
- return js_and_external_sample_count_;
- }
+ unsigned js_sample_count() const { return js_sample_count_; }
+ unsigned external_sample_count() const { return external_sample_count_; }
void StartCountingSamples() {
- is_counting_samples_ = true;
- js_and_external_sample_count_ = 0;
+ js_sample_count_ = 0;
+ external_sample_count_ = 0;
+ is_counting_samples_ = true;
}
class PlatformData;
@@ -125,9 +125,10 @@ class Sampler {
base::Atomic32 has_processing_thread_;
base::Atomic32 active_;
PlatformData* data_; // Platform specific data.
+ // Counts stack samples taken in various VM states.
bool is_counting_samples_;
- // Counts stack samples taken in JS VM state.
- unsigned js_and_external_sample_count_;
+ unsigned js_sample_count_;
+ unsigned external_sample_count_;
DISALLOW_IMPLICIT_CONSTRUCTORS(Sampler);
};
« no previous file with comments | « no previous file | src/profiler/sampler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698