Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 1695643002: Destroy DeviceImpl when the underlying UsbDevice is disconnected. (Closed)

Created:
4 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
4 years, 10 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
reillyg-linux.mtv.corp.google.com:/src/chromium/src@mojo_device_autoclose
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Destroy DeviceImpl when the underlying UsbDevice is disconnected. A open message pipe to a DeviceImpl represents a physical resource, the USB device connected to the host. Instead of continuing to support handling messages sent on this pipe after the device is disconnected it makes more sense to simply close it. For efficiency and because DeviceImpls can outlive the DeviceManagerImpl that created them a new observer interface is added to UsbDevice so that the DeviceImpl can listed for the removal of the physical device all on its own. BUG=492204 Committed: https://crrev.com/1474f931e1e45778c3287bd4f7a20620eafb8ab9 Cr-Commit-Position: refs/heads/master@{#375329}

Patch Set 1 #

Patch Set 2 : Fix upstream. #

Patch Set 3 : Revert change to web_usb_device_impl.cc. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -7 lines) Patch
M device/usb/mock_usb_device.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M device/usb/mock_usb_device.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M device/usb/mojo/device_impl.h View 1 3 chunks +8 lines, -2 lines 0 comments Download
M device/usb/mojo/device_impl.cc View 1 2 chunks +14 lines, -5 lines 0 comments Download
M device/usb/mojo/device_impl_unittest.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M device/usb/usb_device.h View 1 5 chunks +22 lines, -0 lines 0 comments Download
M device/usb/usb_device.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M device/usb/usb_service.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
Reilly Grant (use Gerrit)
Please take a look.
4 years, 10 months ago (2016-02-12 01:01:43 UTC) #2
Ken Rockot(use gerrit already)
Missing files?
4 years, 10 months ago (2016-02-12 01:51:52 UTC) #3
Reilly Grant (use Gerrit)
On 2016/02/12 01:51:52, Ken Rockot wrote: > Missing files? Ah, I see what happened. My ...
4 years, 10 months ago (2016-02-12 02:00:04 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years, 10 months ago (2016-02-12 21:38:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695643002/40001
4 years, 10 months ago (2016-02-12 22:11:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/21680) linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, ...
4 years, 10 months ago (2016-02-12 22:20:49 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695643002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695643002/40001
4 years, 10 months ago (2016-02-13 00:59:19 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-13 02:07:52 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:47:05 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/1474f931e1e45778c3287bd4f7a20620eafb8ab9
Cr-Commit-Position: refs/heads/master@{#375329}

Powered by Google App Engine
This is Rietveld 408576698