device/usb/usb_service.cc - Issue 1695643002: Destroy DeviceImpl when the underlying UsbDevice is disconnected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: device/usb/usb_service.cc

Issue 1695643002: Destroy DeviceImpl when the underlying UsbDevice is disconnected. (Closed) Base URL: reillyg-linux.mtv.corp.google.com:/src/chromium/src@mojo_device_autoclose

Patch Set: Revert change to web_usb_device_impl.cc. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: device/usb/usb_service.cc

diff --git a/device/usb/usb_service.cc b/device/usb/usb_service.cc

index 6909d96c8a059834c0b3750a5a7aabf1cc4ebadf..d0e9d097e3317cb2a3565cc9d165c828eec6b6a4 100644

--- a/device/usb/usb_service.cc

+++ b/device/usb/usb_service.cc

@@ -68,6 +68,7 @@ void UsbService::NotifyDeviceRemoved(scoped_refptr<UsbDevice> device) {

DCHECK(CalledOnValidThread());

FOR_EACH_OBSERVER(Observer, observer_list_, OnDeviceRemoved(device));

+ device->NotifyDeviceRemoved();

FOR_EACH_OBSERVER(Observer, observer_list_, OnDeviceRemovedCleanup(device));

}

« no previous file with comments | « device/usb/usb_device.cc ('k') | no next file » | no next file with comments »