Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 1695633003: [runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. (Closed)

Created:
4 years, 10 months ago by Benedikt Meurer
Modified:
4 years, 10 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Turn ArgumentAccessStub into FastNewSloppyArgumentsStub. Turn the fast case of ArgumentsAccessStub into a new stub FastNewSloppyArgumentsStub, which is similar to the existing FastNewStrictArgumentsStub, although not polished yet, and the slow case always went to the runtime anyway, so we can just directly emit a runtime call there. R=mstarzinger@chromium.org Committed: https://crrev.com/55b0b4f6d572531eec00ab6ebd8f6feb7c584e04 Cr-Commit-Position: refs/heads/master@{#33973} Committed: https://crrev.com/e0129d0f87677722a2cef055e372ab1e805cacf1 Cr-Commit-Position: refs/heads/master@{#33986}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Fix MIPS dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1855 lines, -2110 lines) Patch
M src/arm/code-stubs-arm.cc View 2 chunks +205 lines, -221 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +652 lines, -671 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 2 chunks +8 lines, -5 lines 0 comments Download
M src/code-factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/code-factory.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M src/code-stubs.h View 4 chunks +16 lines, -41 lines 0 comments Download
M src/code-stubs.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M src/compiler/js-create-lowering.cc View 1 2 2 chunks +10 lines, -15 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +4 lines, -16 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +241 lines, -262 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M src/interface-descriptors.h View 4 chunks +8 lines, -13 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 2 chunks +214 lines, -230 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +220 lines, -236 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +218 lines, -240 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 24 (11 generated)
Benedikt Meurer
4 years, 10 months ago (2016-02-12 13:09:00 UTC) #1
Benedikt Meurer
Hey Michi, As discussed offline, here's the renaming and the removal of the awesome slow ...
4 years, 10 months ago (2016-02-12 13:09:38 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695633003/20001
4 years, 10 months ago (2016-02-15 06:05:17 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-15 06:27:42 UTC) #6
Jarin
lgtm
4 years, 10 months ago (2016-02-15 06:56:51 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695633003/20001
4 years, 10 months ago (2016-02-15 06:58:52 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-15 07:04:30 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/55b0b4f6d572531eec00ab6ebd8f6feb7c584e04 Cr-Commit-Position: refs/heads/master@{#33973}
4 years, 10 months ago (2016-02-15 07:05:25 UTC) #13
Michael Achenbach
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1701653002/ by machenbach@chromium.org. ...
4 years, 10 months ago (2016-02-15 08:02:02 UTC) #14
Yang
lgtm
4 years, 10 months ago (2016-02-15 09:29:56 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1695633003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1695633003/40001
4 years, 10 months ago (2016-02-15 10:18:30 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-15 10:38:55 UTC) #22
commit-bot: I haz the power
4 years, 10 months ago (2016-02-15 10:39:47 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e0129d0f87677722a2cef055e372ab1e805cacf1
Cr-Commit-Position: refs/heads/master@{#33986}

Powered by Google App Engine
This is Rietveld 408576698