Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 169513002: Harmony: implement Math.fround. (Closed)

Created:
6 years, 10 months ago by Yang
Modified:
6 years, 10 months ago
Reviewers:
Jarin
CC:
v8-dev
Visibility:
Public.

Description

Harmony: implement Math.fround. R=jarin@chromium.org BUG=v8:2938 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=19433

Patch Set 1 #

Patch Set 2 : updated comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -4 lines) Patch
M src/harmony-math.js View 1 3 chunks +11 lines, -4 lines 0 comments Download
M src/runtime.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +10 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/math-fround.js View 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Yang
6 years, 10 months ago (2014-02-17 10:26:39 UTC) #1
Jarin
lgtm
6 years, 10 months ago (2014-02-18 07:44:57 UTC) #2
Yang
6 years, 10 months ago (2014-02-18 10:43:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r19433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698