Do not use weak handles for ArrayBuffers.

Do not use weak handles for ArrayBuffers.
Instead of allocating weak handles to free ArrayBuffer backing store, dispose of memory while walking the weak list of ArrayBuffers on GC.

Also, free all array buffers on isolate tear-down.


R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=15205

[Dmitry Lomov (no reviews), 2013-06-13 16:40:42]

PTAL

mstarzinger@: please review
hpayer@: FYI (comments welcome, of course!)

[Michael Starzinger, 2013-06-19 11:35:09]

LGTM with nits.

https://codereview.chromium.org/16950013/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1745
src/heap.cc:1745: 
nit: Add a second empty newline.

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1748
src/heap.cc:1748: for (Object* o = array_buffers_list();
nit: Should fit into one line.

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1753
src/heap.cc:1753: }
Let's play it safe and reset array_buffers_list to undefined here.

https://codereview.chromium.org/16950013/diff/1/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/16950013/diff/1/src/heap.h#newcode2195
src/heap.h:2195: void TearDownArrayBuffers();
nit: Let's add a short one-liner comments clarifying that this is only used
during heap tear-down ...

// Destroys all memory allocated for array buffers when heap is torn down.

[Dmitry Lomov (no reviews), 2013-06-19 11:51:25]

Nits addressed, landing

https://codereview.chromium.org/16950013/diff/1/src/heap.cc
File src/heap.cc (right):

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1745
src/heap.cc:1745: 
On 2013/06/19 11:35:09, Michael Starzinger wrote:
> nit: Add a second empty newline.

Done.

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1748
src/heap.cc:1748: for (Object* o = array_buffers_list();
On 2013/06/19 11:35:09, Michael Starzinger wrote:
> nit: Should fit into one line.

Done.

https://codereview.chromium.org/16950013/diff/1/src/heap.cc#newcode1753
src/heap.cc:1753: }
On 2013/06/19 11:35:09, Michael Starzinger wrote:
> Let's play it safe and reset array_buffers_list to undefined here.

Done.

https://codereview.chromium.org/16950013/diff/1/src/heap.h
File src/heap.h (right):

https://codereview.chromium.org/16950013/diff/1/src/heap.h#newcode2195
src/heap.h:2195: void TearDownArrayBuffers();
On 2013/06/19 11:35:09, Michael Starzinger wrote:
> nit: Let's add a short one-liner comments clarifying that this is only used
> during heap tear-down ...
> 
> // Destroys all memory allocated for array buffers when heap is torn down.

Done.

[Dmitry Lomov (no reviews), 2013-06-19 11:53:38]

Committed patchset #1 manually as r15205 (presubmit successful).