Do not use weak handles for ArrayBuffers.

test/cctest/test-weaktypedarrays.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 86 matching lines @@
       v8::HandleScope s2(context->GetIsolate());
       v8::Handle<v8::ArrayBuffer> ab2 = v8::ArrayBuffer::New(128);
 
       Handle<JSArrayBuffer> iab1 = v8::Utils::OpenHandle(*ab1);
       Handle<JSArrayBuffer> iab2 = v8::Utils::OpenHandle(*ab2);
       CHECK_EQ(2, CountArrayBuffersInWeakList(isolate->heap()));
       CHECK(HasArrayBufferInWeakList(isolate->heap(), *iab1));
       CHECK(HasArrayBufferInWeakList(isolate->heap(), *iab2));
     }
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-    isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
     CHECK_EQ(1, CountArrayBuffersInWeakList(isolate->heap()));
     {
       HandleScope scope2(isolate);
       Handle<JSArrayBuffer> iab1 = v8::Utils::OpenHandle(*ab1);
 
       CHECK(HasArrayBufferInWeakList(isolate->heap(), *iab1));
     }
   }
 
   isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-  isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
   CHECK_EQ(0, CountArrayBuffersInWeakList(isolate->heap()));
 }
 
 
 TEST(WeakArrayBuffersFromScript) {
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
 
   for (int i = 1; i <= 3; i++) {
@@ skipping 21 matching lines @@
         CHECK(HasArrayBufferInWeakList(isolate->heap(),
               *v8::Utils::OpenHandle(*ab2)));
         CHECK(HasArrayBufferInWeakList(isolate->heap(),
               *v8::Utils::OpenHandle(*ab3)));
       }
 
       i::ScopedVector<char> source(1024);
       i::OS::SNPrintF(source, "ab%d = null;", i);
       CompileRun(source.start());
       isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-      isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
 
       CHECK_EQ(2, CountArrayBuffersInWeakList(isolate->heap()));
 
       {
         v8::HandleScope s2(context->GetIsolate());
         for (int j = 1; j <= 3; j++) {
           if (j == i) continue;
           i::OS::SNPrintF(source, "ab%d", j);
           v8::Handle<v8::ArrayBuffer> ab =
               v8::Handle<v8::ArrayBuffer>::Cast(CompileRun(source.start()));
           CHECK(HasArrayBufferInWeakList(isolate->heap(),
                 *v8::Utils::OpenHandle(*ab)));
           }
       }
 
       CompileRun("ab1 = null; ab2 = null; ab3 = null;");
     }
 
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-    isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
     CHECK_EQ(0, CountArrayBuffersInWeakList(isolate->heap()));
   }
 }
 
 template <typename TypedArray>
 void TestTypedArrayFromApi() {
   v8::V8::Initialize();
   LocalContext context;
   Isolate* isolate = GetIsolateFrom(&context);
 
   v8::HandleScope s1(context->GetIsolate());
   v8::Handle<v8::ArrayBuffer> ab = v8::ArrayBuffer::New(2048);
   Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
   {
     v8::HandleScope s2(context->GetIsolate());
     v8::Handle<TypedArray> ta1 = TypedArray::New(ab, 0, 256);
     {
       v8::HandleScope s3(context->GetIsolate());
       v8::Handle<TypedArray> ta2 = TypedArray::New(ab, 0, 128);
 
       Handle<JSTypedArray> ita1 = v8::Utils::OpenHandle(*ta1);
       Handle<JSTypedArray> ita2 = v8::Utils::OpenHandle(*ta2);
       CHECK_EQ(2, CountTypedArrays(*iab));
       CHECK(HasTypedArrayInWeakList(*iab, *ita1));
       CHECK(HasTypedArrayInWeakList(*iab, *ita2));
     }
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-    isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
     CHECK_EQ(1, CountTypedArrays(*iab));
     Handle<JSTypedArray> ita1 = v8::Utils::OpenHandle(*ta1);
     CHECK(HasTypedArrayInWeakList(*iab, *ita1));
   }
   isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-  isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
 
   CHECK_EQ(0, CountTypedArrays(*iab));
 }
 
 
 TEST(Uint8ArrayFromApi) {
   TestTypedArrayFromApi<v8::Uint8Array>();
 }
 
 
@@ skipping 72 matching lines @@
       Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
       CHECK_EQ(3, CountTypedArrays(*iab));
       CHECK(HasTypedArrayInWeakList(*iab, *v8::Utils::OpenHandle(*ta1)));
       CHECK(HasTypedArrayInWeakList(*iab, *v8::Utils::OpenHandle(*ta2)));
       CHECK(HasTypedArrayInWeakList(*iab, *v8::Utils::OpenHandle(*ta3)));
     }
 
     i::OS::SNPrintF(source, "ta%d = null;", i);
     CompileRun(source.start());
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-    isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
 
     CHECK_EQ(1, CountArrayBuffersInWeakList(isolate->heap()));
 
     {
       v8::HandleScope s2(context->GetIsolate());
       v8::Handle<v8::ArrayBuffer> ab =
           v8::Handle<v8::ArrayBuffer>::Cast(CompileRun("ab"));
       Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
       CHECK_EQ(2, CountTypedArrays(*iab));
       for (int j = 1; j <= 3; j++) {
         if (j == i) continue;
         i::OS::SNPrintF(source, "ta%d", j);
         v8::Handle<TypedArray> ta =
             v8::Handle<TypedArray>::Cast(CompileRun(source.start()));
         CHECK(HasTypedArrayInWeakList(*iab, *v8::Utils::OpenHandle(*ta)));
       }
     }
 
     CompileRun("ta1 = null; ta2 = null; ta3 = null;");
     isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
-    isolate->heap()->CollectAllGarbage(Heap::kNoGCFlags);
 
     CHECK_EQ(1, CountArrayBuffersInWeakList(isolate->heap()));
 
     {
       v8::HandleScope s3(context->GetIsolate());
       v8::Handle<v8::ArrayBuffer> ab =
           v8::Handle<v8::ArrayBuffer>::Cast(CompileRun("ab"));
       Handle<JSArrayBuffer> iab = v8::Utils::OpenHandle(*ab);
       CHECK_EQ(0, CountTypedArrays(*iab));
     }
@@ skipping 38 matching lines @@
 
 TEST(Float64ArrayFromScript) {
   TestTypedArrayFromScript<v8::Float64Array>("Float64Array");
 }
 
 
 TEST(Uint8ClampedArrayFromScript) {
   TestTypedArrayFromScript<v8::Uint8ClampedArray>("Uint8ClampedArray");
 }