Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1694963002: Change who allocated the MediaPipe's shared buffer. (Closed)

Created:
4 years, 10 months ago by johngro
Modified:
4 years, 10 months ago
Reviewers:
dalesat, jeffbrown
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Change who allocated the MediaPipe's shared buffer. Have the MediaPipe's implementor receive a client allocated shared buffer instead of having the client fetch a shared buffer from the implementor. BUG= R=dalesat@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/64a3e0d941833dbcf88a609d560d506a7f014f4c

Patch Set 1 #

Patch Set 2 : Fix android trybots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -423 lines) Patch
M examples/audio_play_test/play_tone.cc View 2 chunks +1 line, -1 line 0 comments Download
M examples/audio_play_test/play_wav.cc View 2 chunks +1 line, -1 line 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/audio_track.mojom.dart View 5 chunks +5 lines, -19 lines 0 comments Download
M mojo/dart/packages/mojo_services/lib/mojo/media/media_pipe.mojom.dart View 10 chunks +31 lines, -205 lines 0 comments Download
M mojo/services/media/audio/interfaces/audio_track.mojom View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.h View 5 chunks +26 lines, -5 lines 0 comments Download
M mojo/services/media/common/cpp/circular_buffer_media_pipe_adapter.cc View 4 chunks +57 lines, -77 lines 0 comments Download
M mojo/services/media/common/interfaces/media_pipe.mojom View 3 chunks +4 lines, -22 lines 0 comments Download
M services/media/audio/audio_track_impl.cc View 1 chunk +3 lines, -17 lines 0 comments Download
M services/media/common/media_pipe_base.h View 3 chunks +7 lines, -7 lines 0 comments Download
M services/media/common/media_pipe_base.cc View 1 5 chunks +43 lines, -66 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
johngro
4 years, 10 months ago (2016-02-12 23:13:16 UTC) #2
dalesat
lgtm
4 years, 10 months ago (2016-02-16 17:35:34 UTC) #3
dalesat
lgtm
4 years, 10 months ago (2016-02-16 17:35:35 UTC) #4
johngro
4 years, 10 months ago (2016-02-16 19:32:56 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
64a3e0d941833dbcf88a609d560d506a7f014f4c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698