Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: services/media/common/media_pipe_base.h

Issue 1694963002: Change who allocated the MediaPipe's shared buffer. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Fix android trybots Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/media/audio/audio_track_impl.cc ('k') | services/media/common/media_pipe_base.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/media/common/media_pipe_base.h
diff --git a/services/media/common/media_pipe_base.h b/services/media/common/media_pipe_base.h
index 07bea6561ed801b5b4fd95093c9261b51159c9f5..9e7499fd656e1a7df04b44a9d906afa8f78f5712 100644
--- a/services/media/common/media_pipe_base.h
+++ b/services/media/common/media_pipe_base.h
@@ -50,8 +50,7 @@ class MediaPipeBase : public MediaPipe {
~MediaPipeBase() override;
// Initialize the internal state of the pipe (allocate resources, etc..)
- MojoResult Init(InterfaceRequest<MediaPipe> request,
- uint64_t shared_buffer_size);
+ MojoResult Init(InterfaceRequest<MediaPipe> request);
bool IsInitialized() const;
void Reset();
@@ -59,15 +58,16 @@ class MediaPipeBase : public MediaPipe {
protected:
class MappedSharedBuffer {
public:
- static MappedSharedBufferPtr Create(size_t size);
+ static MappedSharedBufferPtr Create(ScopedSharedBufferHandle handle,
+ uint64_t size);
~MappedSharedBuffer();
const ScopedSharedBufferHandle& handle() const { return handle_; }
- size_t size() const { return size_; }
- void* base() const { return base_; }
+ uint64_t size() const { return size_; }
+ void* base() const { return base_; }
private:
- explicit MappedSharedBuffer(size_t size);
+ MappedSharedBuffer(ScopedSharedBufferHandle handle, size_t size);
ScopedSharedBufferHandle handle_;
size_t size_;
@@ -84,7 +84,7 @@ class MediaPipeBase : public MediaPipe {
Binding<MediaPipe> binding_;
// MediaPipe.mojom implementation.
- void GetState(const GetStateCallback& cbk) final;
+ void SetBuffer(ScopedSharedBufferHandle handle, uint64_t size) final;
void SendPacket(MediaPacketPtr packet,
const SendPacketCallback& cbk) final;
void Flush(const FlushCallback& cbk) final;
« no previous file with comments | « services/media/audio/audio_track_impl.cc ('k') | services/media/common/media_pipe_base.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698