chrome/browser/notifications/notification_permission_context.cc - Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_permission_context.cc

Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: recover ClearSetting() for user input patterns to use SetContentSetting() directly Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/notification_permission_context.cc

diff --git a/chrome/browser/notifications/notification_permission_context.cc b/chrome/browser/notifications/notification_permission_context.cc

index 497abf28ba6ab8f6b4b5a9bcea1e7f76509aff3e..c156dac8824d0aafdbb873e2121e2d7c0439bd1d 100644

--- a/chrome/browser/notifications/notification_permission_context.cc

+++ b/chrome/browser/notifications/notification_permission_context.cc

@@ -170,8 +170,7 @@ NotificationPermissionContext::~NotificationPermissionContext() {}

void NotificationPermissionContext::ResetPermission(

const GURL& requesting_origin,

const GURL& embedder_origin) {

- DesktopNotificationProfileUtil::ClearSetting(

- profile(), ContentSettingsPattern::FromURLNoWildcard(requesting_origin));

+ DesktopNotificationProfileUtil::ClearSetting(profile(), requesting_origin);

}

void NotificationPermissionContext::CancelPermissionRequest(

« chrome/browser/notifications/message_center_settings_controller.cc ('K') | « chrome/browser/notifications/notification_browsertest.cc ('k') | no next file » | no next file with comments »