chrome/browser/notifications/notification_browsertest.cc - Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_browsertest.cc

Issue 1694923004: Use GURLs instead of patterns in SetContentSetting in notifications (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: recover ClearSetting() for user input patterns to use SetContentSetting() directly Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/message_center_settings_controller.cc ('K') | « chrome/browser/notifications/message_center_settings_controller.cc ('k') | chrome/browser/notifications/notification_permission_context.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_browsertest.cc

diff --git a/chrome/browser/notifications/notification_browsertest.cc b/chrome/browser/notifications/notification_browsertest.cc

index 4e19c5453385e6ee9e163f266ce1d014a516bfa3..6362499ace1fec6eacb5667af178078d42244238 100644

--- a/chrome/browser/notifications/notification_browsertest.cc

+++ b/chrome/browser/notifications/notification_browsertest.cc

@@ -387,8 +387,7 @@ bool NotificationsTest::CheckOriginInSetting(

}

void NotificationsTest::DropOriginPreference(const GURL& origin) {

- DesktopNotificationProfileUtil::ClearSetting(browser()->profile(),

- ContentSettingsPattern::FromURLNoWildcard(origin));

+ DesktopNotificationProfileUtil::ClearSetting(browser()->profile(), origin);

}

// Flaky on Windows, Mac, Linux: http://crbug.com/437414.