chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java - Issue 1694863003: Refactor the offline page storage to include client namespace and id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: move id generation to C++, add DB migration Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkEditActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

index 637f091e6e1a34339ba645cbba0eabbe27706f93..4314f06f12fd3906a7c7cb119993aff348823ed0 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

@@ -237,7 +237,7 @@ public class BookmarkModel extends BookmarkBridge {

webContents.isIncognito());

mOfflinePageBridge.savePage(webContents, bookmarkId, new SavePageCallback() {

@Override

- public void onSavePageDone(int savePageResult, String url) {

+ public void onSavePageDone(int savePageResult, String url, long offlineId) {

int saveResult;

if (savePageResult == SavePageResult.SUCCESS) {

saveResult = AddBookmarkCallback.SAVED;