Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: move id generation to C++, add DB migration Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.bookmarks; 5 package org.chromium.chrome.browser.bookmarks;
6 6
7 import org.chromium.base.ObserverList; 7 import org.chromium.base.ObserverList;
8 import org.chromium.base.VisibleForTesting; 8 import org.chromium.base.VisibleForTesting;
9 import org.chromium.base.metrics.RecordHistogram; 9 import org.chromium.base.metrics.RecordHistogram;
10 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge; 10 import org.chromium.chrome.browser.offlinepages.OfflinePageBridge;
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
230 * @param callback The callback to be invoked when the offline copy is saved. 230 * @param callback The callback to be invoked when the offline copy is saved.
231 */ 231 */
232 public void saveOfflinePage(final BookmarkId bookmarkId, WebContents webCont ents, 232 public void saveOfflinePage(final BookmarkId bookmarkId, WebContents webCont ents,
233 final AddBookmarkCallback callback) { 233 final AddBookmarkCallback callback) {
234 assert bookmarkId.getId() != ChromeBrowserProviderClient.INVALID_BOOKMAR K_ID; 234 assert bookmarkId.getId() != ChromeBrowserProviderClient.INVALID_BOOKMAR K_ID;
235 if (mOfflinePageBridge != null) { 235 if (mOfflinePageBridge != null) {
236 RecordHistogram.recordBooleanHistogram("OfflinePages.IncognitoSave", 236 RecordHistogram.recordBooleanHistogram("OfflinePages.IncognitoSave",
237 webContents.isIncognito()); 237 webContents.isIncognito());
238 mOfflinePageBridge.savePage(webContents, bookmarkId, new SavePageCal lback() { 238 mOfflinePageBridge.savePage(webContents, bookmarkId, new SavePageCal lback() {
239 @Override 239 @Override
240 public void onSavePageDone(int savePageResult, String url) { 240 public void onSavePageDone(int savePageResult, String url, long offlineId) {
241 int saveResult; 241 int saveResult;
242 if (savePageResult == SavePageResult.SUCCESS) { 242 if (savePageResult == SavePageResult.SUCCESS) {
243 saveResult = AddBookmarkCallback.SAVED; 243 saveResult = AddBookmarkCallback.SAVED;
244 } else if (savePageResult == SavePageResult.SKIPPED) { 244 } else if (savePageResult == SavePageResult.SKIPPED) {
245 saveResult = AddBookmarkCallback.SKIPPED; 245 saveResult = AddBookmarkCallback.SKIPPED;
246 } else { 246 } else {
247 saveResult = AddBookmarkCallback.ERROR; 247 saveResult = AddBookmarkCallback.ERROR;
248 } 248 }
249 callback.onBookmarkAdded(bookmarkId, saveResult); 249 callback.onBookmarkAdded(bookmarkId, saveResult);
250 } 250 }
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
308 return bookmarkIds; 308 return bookmarkIds;
309 } 309 }
310 310
311 /** 311 /**
312 * @return Offline page bridge. 312 * @return Offline page bridge.
313 */ 313 */
314 public OfflinePageBridge getOfflinePageBridge() { 314 public OfflinePageBridge getOfflinePageBridge() {
315 return mOfflinePageBridge; 315 return mOfflinePageBridge;
316 } 316 }
317 } 317 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698