Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 1694863003: Refactor the offline page storage to include client namespace and id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_bridge.h
diff --git a/chrome/browser/android/offline_pages/offline_page_bridge.h b/chrome/browser/android/offline_pages/offline_page_bridge.h
index 0bfe92be4d5a8060365e9064f2b225e424c1a105..ef2f12044f6d555b6d2adfb7921c918b51fa2b0f 100644
--- a/chrome/browser/android/offline_pages/offline_page_bridge.h
+++ b/chrome/browser/android/offline_pages/offline_page_bridge.h
@@ -43,7 +43,7 @@ class OfflinePageBridge : public OfflinePageModel::Observer {
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jobject>& j_result_obj);
- base::android::ScopedJavaLocalRef<jobject> GetPageByBookmarkId(
+ base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
jlong bookmark_id);
fgorski 2016/02/12 21:43:40 nit: offline_id?
bburns 2016/02/20 01:14:17 Done.
@@ -57,7 +57,9 @@ class OfflinePageBridge : public OfflinePageModel::Observer {
const base::android::JavaParamRef<jobject>& obj,
const base::android::JavaParamRef<jobject>& j_callback_obj,
const base::android::JavaParamRef<jobject>& j_web_contents,
- jlong bookmark_id);
+ jlong offline_id,
+ jstring client_id_namespace,
fgorski 2016/02/12 21:43:40 nit: j_ for j_strings, as they cannot be directly
bburns 2016/02/20 01:14:18 Done I think?
+ jstring client_id);
void MarkPageAccessed(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,

Powered by Google App Engine
This is Rietveld 408576698