Refactor the offline page storage to include client namespace and id.

chrome/browser/android/offline_pages/offline_page_bridge.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
 
 #include <stdint.h>
 
 #include "base/android/jni_android.h"
@@ skipping 25 matching lines @@
   void OfflinePageDeleted(int64_t bookmark_id) override;
 
   void GetAllPages(JNIEnv* env,
                    const base::android::JavaParamRef<jobject>& obj,
                    const base::android::JavaParamRef<jobject>& j_result_obj);
   void GetPagesToCleanUp(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jobject>& j_result_obj);
 
-  base::android::ScopedJavaLocalRef<jobject> GetPageByBookmarkId(
+  base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       jlong bookmark_id);

[fgorski, 2016/02/12 21:43:40]

nit: offline_id?

[bburns, 2016/02/20 01:14:17]

Done.

 
   base::android::ScopedJavaLocalRef<jobject> GetPageByOnlineURL(
       JNIEnv* env,
       const base::android::JavaParamRef<jobject>& obj,
       const base::android::JavaParamRef<jstring>& online_url);
 
   void SavePage(JNIEnv* env,
                 const base::android::JavaParamRef<jobject>& obj,
                 const base::android::JavaParamRef<jobject>& j_callback_obj,
                 const base::android::JavaParamRef<jobject>& j_web_contents,
-                jlong bookmark_id);
+                jlong offline_id,
+                jstring client_id_namespace,

[fgorski, 2016/02/12 21:43:40]

nit: j_ for j_strings, as they cannot be directly used.

[bburns, 2016/02/20 01:14:18]

Done I think?

+                jstring client_id);
 
   void MarkPageAccessed(JNIEnv* env,
                         const base::android::JavaParamRef<jobject>& obj,
                         jlong bookmark_id);
 
   void DeletePage(JNIEnv* env,
                   const base::android::JavaParamRef<jobject>& obj,
                   const base::android::JavaParamRef<jobject>& j_callback_obj,
                   jlong bookmark_id);
 
@@ skipping 33 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge);
 };
 
 bool RegisterOfflinePageBridge(JNIEnv* env);
 
 }  // namespace android
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_