Check length of String before checking if it's 8/16 bit

Check length of String before checking if it's 8/16 bit

String::is8Bit() can't be called on 'null' Strings, so check if the
length is zero first.

BUG=586135
Committed: https://crrev.com/73408f40725d9a738c12a61b51bece069ca5dd53
Cr-Commit-Position: refs/heads/master@{#375451}

[fs, 2016-02-12 13:53:54]

fs@opera.com changed reviewers:
+ tkent@chromium.org, yoav@yoav.ws

[tkent, 2016-02-14 23:34:32]

lgtm.

However, I prefer C++ unit test rather than a layout test for such kind of bugs.

[Yoav Weiss, 2016-02-15 08:48:17]

On 2016/02/14 23:34:32, tkent wrote:
> lgtm.
> 
> However, I prefer C++ unit test rather than a layout test for such kind of
bugs.

lgtm2

[fs, 2016-02-15 09:24:36]

On 2016/02/14 at 23:34:32, tkent wrote:
> lgtm.
> 
> However, I prefer C++ unit test rather than a layout test for such kind of
bugs.

Yeah, that makes sense (almost strange there isn't one for this file already).
Replaced layout test with unit test.

[fs, 2016-02-15 12:00:20]

The CQ bit was checked by fs@opera.com

[fs, 2016-02-15 12:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1694773002/#ps40001
(title: "Add CORE_EXPORT")

[commit-bot: I haz the power, 2016-02-15 12:00:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694773002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694773002/40001

[commit-bot: I haz the power, 2016-02-15 13:13:59]

Committed patchset #3 (id:40001)

[tkent, 2016-02-16 00:00:35]

https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp
(right):

https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp:16:
EXPECT_EQ(numbers.size(), 0u);
The argument order of EXPECT_EQ is:
  expected value, actual value

If the arguments don't match to this order, a test failure message would be
strange.

[fs, 2016-02-16 08:46:16]

On 2016/02/16 at 00:00:35, tkent wrote:
>
https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp
(right):
> 
>
https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Sour...
> third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp:16:
EXPECT_EQ(numbers.size(), 0u);
> The argument order of EXPECT_EQ is:
>   expected value, actual value
> 
> If the arguments don't match to this order, a test failure message would be
strange.

Oh yes, I always forget about this (and maybe needless to say, but don't find it
very intuitive...) Will fix up.

[commit-bot: I haz the power, 2016-02-16 22:49:53]

Description was changed from

==========
Check length of String before checking if it's 8/16 bit

String::is8Bit() can't be called on 'null' Strings, so check if the
length is zero first.

BUG=586135
==========

to

==========
Check length of String before checking if it's 8/16 bit

String::is8Bit() can't be called on 'null' Strings, so check if the
length is zero first.

BUG=586135

Committed: https://crrev.com/73408f40725d9a738c12a61b51bece069ca5dd53
Cr-Commit-Position: refs/heads/master@{#375451}
==========

[commit-bot: I haz the power, 2016-02-16 22:49:53]

Patchset 3 (id:??) landed as
https://crrev.com/73408f40725d9a738c12a61b51bece069ca5dd53
Cr-Commit-Position: refs/heads/master@{#375451}