Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 1694773002: Check length of String before checking if it's 8/16 bit (Closed)

Created:
4 years, 10 months ago by fs
Modified:
4 years, 10 months ago
Reviewers:
tkent, Yoav Weiss
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check length of String before checking if it's 8/16 bit String::is8Bit() can't be called on 'null' Strings, so check if the length is zero first. BUG=586135 Committed: https://crrev.com/73408f40725d9a738c12a61b51bece069ca5dd53 Cr-Commit-Position: refs/heads/master@{#375451}

Patch Set 1 #

Patch Set 2 : Replace layout test with unittest #

Patch Set 3 : Add CORE_EXPORT #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -4 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp View 1 chunk +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp View 1 1 chunk +21 lines, -0 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
fs
4 years, 10 months ago (2016-02-12 13:53:55 UTC) #2
tkent
lgtm. However, I prefer C++ unit test rather than a layout test for such kind ...
4 years, 10 months ago (2016-02-14 23:34:32 UTC) #3
Yoav Weiss
On 2016/02/14 23:34:32, tkent wrote: > lgtm. > > However, I prefer C++ unit test ...
4 years, 10 months ago (2016-02-15 08:48:17 UTC) #4
fs
On 2016/02/14 at 23:34:32, tkent wrote: > lgtm. > > However, I prefer C++ unit ...
4 years, 10 months ago (2016-02-15 09:24:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694773002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694773002/40001
4 years, 10 months ago (2016-02-15 12:00:31 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-15 13:13:59 UTC) #9
tkent
https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp File third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp (right): https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp#newcode16 third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp:16: EXPECT_EQ(numbers.size(), 0u); The argument order of EXPECT_EQ is: expected ...
4 years, 10 months ago (2016-02-16 00:00:35 UTC) #10
fs
On 2016/02/16 at 00:00:35, tkent wrote: > https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp > File third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp (right): > > https://codereview.chromium.org/1694773002/diff/40001/third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp#newcode16 ...
4 years, 10 months ago (2016-02-16 08:46:16 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 22:49:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/73408f40725d9a738c12a61b51bece069ca5dd53
Cr-Commit-Position: refs/heads/master@{#375451}

Powered by Google App Engine
This is Rietveld 408576698