third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h - Issue 1694773002: Check length of String before checking if it's 8/16 bit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h

Issue 1694773002: Check length of String before checking if it's 8/16 bit (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add CORE_EXPORT Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.cpp » ('j') | third_party/WebKit/Source/core/html/parser/HTMLParserIdiomsTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h b/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h

index 6d557db82129028ab7f14f0026523c17c1774176..9d27b40cd7d2eef384a845b707fead9a7b3e4ca5 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLParserIdioms.h

@@ -25,6 +25,7 @@

#ifndef HTMLParserIdioms_h

#define HTMLParserIdioms_h

+#include "core/CoreExport.h"

#include "core/dom/QualifiedName.h"

#include "platform/Decimal.h"

#include "wtf/Forward.h"

@@ -61,7 +62,7 @@ bool parseHTMLInteger(const String&, int&);

bool parseHTMLNonNegativeInteger(const String&, unsigned&);

// https://html.spec.whatwg.org/multipage/infrastructure.html#rules-for-parsing-a-list-of-floating-point-numbers

-Vector<double> parseHTMLListOfFloatingPointNumbers(const String&);

+CORE_EXPORT Vector<double> parseHTMLListOfFloatingPointNumbers(const String&);

typedef Vector<std::pair<String, String>> HTMLAttributeList;

// The returned encoding might not be valid.