chromeos/network/onc/onc_translator_unittest.cc - Issue 16946002: Resolve certificate references in ONC by PEM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_translator_unittest.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added a unit test for the resolve function. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_translator_unittest.cc

diff --git a/chromeos/network/onc/onc_translator_unittest.cc b/chromeos/network/onc/onc_translator_unittest.cc

index 5365b0b7d3c41d30859a8699172a804ba9888106..9a6efc6ad34f3196d7bbf52946ba833e18d975cc 100644

--- a/chromeos/network/onc/onc_translator_unittest.cc

+++ b/chromeos/network/onc/onc_translator_unittest.cc

@@ -44,15 +44,16 @@ INSTANTIATE_TEST_CASE_P(

::testing::Values(

std::make_pair("managed_ethernet.onc", "shill_ethernet.json"),

std::make_pair("valid_wifi_psk.onc", "shill_wifi_psk.json"),

- std::make_pair("valid_wifi_clientcert.onc",

+ std::make_pair("wifi_clientcert_with_cert_pems.onc",

"shill_wifi_clientcert.json"),

std::make_pair("valid_wifi_clientref.onc",

"shill_wifi_clientref.json"),

std::make_pair("valid_l2tpipsec.onc", "shill_l2tpipsec.json"),

- std::make_pair("valid_l2tpipsec_clientcert.onc",

+ std::make_pair("l2tpipsec_clientcert_with_cert_pems.onc",

"shill_l2tpipsec_clientcert.json"),

- std::make_pair("valid_openvpn.onc", "shill_openvpn.json"),

- std::make_pair("valid_openvpn_clientcert.onc",

+ std::make_pair("valid_openvpn_with_cert_pems.onc",

+ "shill_openvpn.json"),

+ std::make_pair("openvpn_clientcert_with_cert_pems.onc",

"shill_openvpn_clientcert.json")));

// First parameter: Filename of source Shill json.

@@ -87,7 +88,7 @@ INSTANTIATE_TEST_CASE_P(

std::make_pair("shill_l2tpipsec.json",

"translation_of_shill_l2tpipsec.onc"),

std::make_pair("shill_openvpn.json",

- "valid_openvpn.onc"),

+ "translation_of_shill_openvpn.onc"),

std::make_pair("shill_openvpn_with_errors.json",

"translation_of_shill_openvpn_with_errors.onc"),

std::make_pair("shill_wifi_with_state.json",