Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1941)

Side by Side Diff: chromeos/network/onc/onc_translator_unittest.cc

Issue 16946002: Resolve certificate references in ONC by PEM. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added a unit test for the resolve function. Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chromeos/network/onc/onc_translator_onc_to_shill.cc ('k') | chromeos/network/onc/onc_utils.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromeos/network/onc/onc_translator.h" 5 #include "chromeos/network/onc/onc_translator.h"
6 6
7 #include "base/memory/scoped_ptr.h" 7 #include "base/memory/scoped_ptr.h"
8 #include "base/values.h" 8 #include "base/values.h"
9 #include "chromeos/network/onc/onc_constants.h" 9 #include "chromeos/network/onc/onc_constants.h"
10 #include "chromeos/network/onc/onc_signature.h" 10 #include "chromeos/network/onc/onc_signature.h"
(...skipping 26 matching lines...) Expand all
37 } 37 }
38 38
39 // Test different network types, such that each ONC object type is tested at 39 // Test different network types, such that each ONC object type is tested at
40 // least once. 40 // least once.
41 INSTANTIATE_TEST_CASE_P( 41 INSTANTIATE_TEST_CASE_P(
42 ONCTranslatorOncToShillTest, 42 ONCTranslatorOncToShillTest,
43 ONCTranslatorOncToShillTest, 43 ONCTranslatorOncToShillTest,
44 ::testing::Values( 44 ::testing::Values(
45 std::make_pair("managed_ethernet.onc", "shill_ethernet.json"), 45 std::make_pair("managed_ethernet.onc", "shill_ethernet.json"),
46 std::make_pair("valid_wifi_psk.onc", "shill_wifi_psk.json"), 46 std::make_pair("valid_wifi_psk.onc", "shill_wifi_psk.json"),
47 std::make_pair("valid_wifi_clientcert.onc", 47 std::make_pair("wifi_clientcert_with_cert_pems.onc",
48 "shill_wifi_clientcert.json"), 48 "shill_wifi_clientcert.json"),
49 std::make_pair("valid_wifi_clientref.onc", 49 std::make_pair("valid_wifi_clientref.onc",
50 "shill_wifi_clientref.json"), 50 "shill_wifi_clientref.json"),
51 std::make_pair("valid_l2tpipsec.onc", "shill_l2tpipsec.json"), 51 std::make_pair("valid_l2tpipsec.onc", "shill_l2tpipsec.json"),
52 std::make_pair("valid_l2tpipsec_clientcert.onc", 52 std::make_pair("l2tpipsec_clientcert_with_cert_pems.onc",
53 "shill_l2tpipsec_clientcert.json"), 53 "shill_l2tpipsec_clientcert.json"),
54 std::make_pair("valid_openvpn.onc", "shill_openvpn.json"), 54 std::make_pair("valid_openvpn_with_cert_pems.onc",
55 std::make_pair("valid_openvpn_clientcert.onc", 55 "shill_openvpn.json"),
56 std::make_pair("openvpn_clientcert_with_cert_pems.onc",
56 "shill_openvpn_clientcert.json"))); 57 "shill_openvpn_clientcert.json")));
57 58
58 // First parameter: Filename of source Shill json. 59 // First parameter: Filename of source Shill json.
59 // Second parameter: Filename of expected translated ONC network part. 60 // Second parameter: Filename of expected translated ONC network part.
60 // 61 //
61 // Note: This translation direction doesn't have to reconstruct all of the ONC 62 // Note: This translation direction doesn't have to reconstruct all of the ONC
62 // fields, as Chrome doesn't need all of a Service's properties. 63 // fields, as Chrome doesn't need all of a Service's properties.
63 class ONCTranslatorShillToOncTest 64 class ONCTranslatorShillToOncTest
64 : public ::testing::TestWithParam<std::pair<std::string, std::string> > { 65 : public ::testing::TestWithParam<std::pair<std::string, std::string> > {
65 }; 66 };
(...skipping 14 matching lines...) Expand all
80 translation.get())); 81 translation.get()));
81 } 82 }
82 83
83 INSTANTIATE_TEST_CASE_P( 84 INSTANTIATE_TEST_CASE_P(
84 ONCTranslatorShillToOncTest, 85 ONCTranslatorShillToOncTest,
85 ONCTranslatorShillToOncTest, 86 ONCTranslatorShillToOncTest,
86 ::testing::Values( 87 ::testing::Values(
87 std::make_pair("shill_l2tpipsec.json", 88 std::make_pair("shill_l2tpipsec.json",
88 "translation_of_shill_l2tpipsec.onc"), 89 "translation_of_shill_l2tpipsec.onc"),
89 std::make_pair("shill_openvpn.json", 90 std::make_pair("shill_openvpn.json",
90 "valid_openvpn.onc"), 91 "translation_of_shill_openvpn.onc"),
91 std::make_pair("shill_openvpn_with_errors.json", 92 std::make_pair("shill_openvpn_with_errors.json",
92 "translation_of_shill_openvpn_with_errors.onc"), 93 "translation_of_shill_openvpn_with_errors.onc"),
93 std::make_pair("shill_wifi_with_state.json", 94 std::make_pair("shill_wifi_with_state.json",
94 "translation_of_shill_wifi_with_state.onc"))); 95 "translation_of_shill_wifi_with_state.onc")));
95 96
96 } // namespace onc 97 } // namespace onc
97 } // namespace chromeos 98 } // namespace chromeos
OLDNEW
« no previous file with comments | « chromeos/network/onc/onc_translator_onc_to_shill.cc ('k') | chromeos/network/onc/onc_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698