Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1694403003: Modify interface to GrPathUtils::convertCubicToQuads (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
ethannicholas
CC:
reviews_skia.org, Joel.Liang
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : update comments #

Patch Set 3 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -25 lines) Patch
M src/gpu/GrPathUtils.h View 1 1 chunk +11 lines, -10 lines 0 comments Download
M src/gpu/GrPathUtils.cpp View 1 2 1 chunk +18 lines, -6 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAHairLinePathRenderer.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/gpu/batches/GrPLSPathRenderer.cpp View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
bsalomon
4 years, 10 months ago (2016-02-16 15:11:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403003/40001
4 years, 10 months ago (2016-02-16 15:11:17 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-16 15:35:32 UTC) #7
ethannicholas
lgtm
4 years, 10 months ago (2016-02-16 15:55:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694403003/40001
4 years, 10 months ago (2016-02-16 15:59:15 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-16 16:00:08 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/18fab30d7c4858ef2521e0380573aac5a21b2ed9

Powered by Google App Engine
This is Rietveld 408576698