Simplify CSS variables resolution logic [2 of 2]

third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

Index: third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h
diff --git a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h
index bb740d87184c906ff91e4cc7d5c190cc88096305..790afed178a90e5391e896949072e7a4e7a74c5c 100644
--- a/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h
+++ b/third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h
@@ -14,6 +14,7 @@
 namespace blink {
 
 class CSSParserTokenRange;
+class CSSVariableData;
 class CSSVariableReferenceValue;
 class StyleResolverState;
 class StyleVariableData;
@@ -28,12 +29,15 @@ public:
 
 private:
     CSSVariableResolver(StyleVariableData*);
-    CSSVariableResolver(StyleVariableData*, AtomicString& variable);
 
     // Returns false if we encounter a reference to an invalid variable with no fallback
     bool resolveFallback(CSSParserTokenRange, Vector<CSSParserToken>& result);
-    bool resolveVariableTokensRecursive(CSSParserTokenRange, Vector<CSSParserToken>& result);
-    bool resolveVariableReferencesFromTokens(CSSParserTokenRange tokens, Vector<CSSParserToken>& result);
+    bool resolveVariableReference(CSSParserTokenRange, Vector<CSSParserToken>& result);

[shans, 2016/02/17 04:04:15]

This is a good opportunity to document what these functions do. Just a
once-sentence description.

+    bool resolveTokenRange(CSSParserTokenRange, Vector<CSSParserToken>& result);
+
+    // Returns null if the custom property is invalid
+    CSSVariableData* valueForCustomProperty(AtomicString name);
+    PassRefPtr<CSSVariableData> resolveCustomProperty(AtomicString name, const CSSVariableData&);

[shans, 2016/02/17 04:04:15]

(and these)

 
     StyleVariableData* m_styleVariableData;
     HashSet<AtomicString> m_variablesSeen;