Simplify CSS variables resolution logic [2 of 2]

third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CSSVariableResolver_h
 #define CSSVariableResolver_h
 
 #include "core/CSSPropertyNames.h"
 #include "core/css/parser/CSSParserToken.h"
 #include "wtf/HashSet.h"
 #include "wtf/text/AtomicString.h"
 #include "wtf/text/AtomicStringHash.h"
 
 namespace blink {
 
 class CSSParserTokenRange;
+class CSSVariableData;
 class CSSVariableReferenceValue;
 class StyleResolverState;
 class StyleVariableData;
 
 class CSSVariableResolver {
 public:
     static void resolveVariableDefinitions(StyleVariableData*);
     static void resolveAndApplyVariableReferences(StyleResolverState&, CSSPropertyID, const CSSVariableReferenceValue&);
 
     // Shorthand properties are not supported.
     static PassRefPtrWillBeRawPtr<CSSValue> resolveVariableReferences(StyleVariableData*, CSSPropertyID, const CSSVariableReferenceValue&);
 
 private:
     CSSVariableResolver(StyleVariableData*);
-    CSSVariableResolver(StyleVariableData*, AtomicString& variable);
 
     // Returns false if we encounter a reference to an invalid variable with no fallback
     bool resolveFallback(CSSParserTokenRange, Vector<CSSParserToken>& result);
-    bool resolveVariableTokensRecursive(CSSParserTokenRange, Vector<CSSParserToken>& result);
-    bool resolveVariableReferencesFromTokens(CSSParserTokenRange tokens, Vector<CSSParserToken>& result);
+    bool resolveVariableReference(CSSParserTokenRange, Vector<CSSParserToken>& result);

[shans, 2016/02/17 04:04:15]

This is a good opportunity to document what these functions do. Just a
once-sentence description.

+    bool resolveTokenRange(CSSParserTokenRange, Vector<CSSParserToken>& result);
+
+    // Returns null if the custom property is invalid
+    CSSVariableData* valueForCustomProperty(AtomicString name);
+    PassRefPtr<CSSVariableData> resolveCustomProperty(AtomicString name, const CSSVariableData&);

[shans, 2016/02/17 04:04:15]

(and these)

 
     StyleVariableData* m_styleVariableData;
     HashSet<AtomicString> m_variablesSeen;
     // Resolution doesn't finish when a cycle is detected. Fallbacks still
     // need to be tracked for additional cycles, and invalidation only
     // applies back to cycle starts.
     HashSet<AtomicString> m_cycleStartPoints;
 };
 
 } // namespace blink
 
 #endif // CSSVariableResolver