Rename EnhancedBookmarks to Bookmarks, part 2.

Rename EnhancedBookmarks to Bookmarks, part 2.

There is only one bookmarks UI now, so we can simplify the naming. This
renames resources and strings and updates comments to remove all
remaining references to "enhanced" bookmarks. Primary changes:

 - resource filenames: replace "eb_" prefix with "bookmark_"
 - strings: replace IDS_ENHANCED_BOOKMARK with IDS_BOOKMARK
 - styles: replace "EnhancedBookmark" with "Bookmark"
 - comments: remove "enhanced"

Note: a few references to "enhanced" bookmarks can't be changed: metrics
names, and shared pref names.

BUG=474719
Committed: https://crrev.com/f545152772661ba2fc3a6bde9e776f132bad1ada
Cr-Commit-Position: refs/heads/master@{#375726}

[newt (away), 2016-02-16 21:35:27]

newt@chromium.org changed reviewers:
+ ianwen@chromium.org

[newt (away), 2016-02-16 21:35:28]

PTAL

[Ian Wen, 2016-02-16 22:15:43]

lgtm! Woohoo, let's say good by to the word "enhanced"! :P

+danduong@ FYI.

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivityBase.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivityBase.java:16:
* Activity base class that all the Bookmark activities inherit. Currently it's
responsible
s/Bookmark/bookmark ?

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java:31:
* BaseAdapter for BookmarkItemsContainer. It manages bookmarks to list there.
Maybe use a javadoc link here? {@link BookmarkItemsContainer}?

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java:145:
* Add an observer that listens to delete events that go through bookmark model.
the bookmark model?

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java:34:
* Create a new instance of an bookmark page.
a bookmark page?

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java:110:
R.style.BookmarkMenuStyle);
Can we push #110 to #109 now?

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
(right):

https://chromiumcodereview.appspot.com/1694093003/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java:453:
* Closes the Bookmark Activity on Phone. Does nothing on tablet.
A javadoc link here?

[newt (away), 2016-02-16 23:49:50]

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivityBase.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivityBase.java:16:
* Activity base class that all the Bookmark activities inherit. Currently it's
responsible
On 2016/02/16 22:15:42, Ian Wen wrote:
> s/Bookmark/bookmark ?

Done.

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkItemsAdapter.java:31:
* BaseAdapter for BookmarkItemsContainer. It manages bookmarks to list there.
On 2016/02/16 22:15:43, Ian Wen wrote:
> Maybe use a javadoc link here? {@link BookmarkItemsContainer}?

Done. Also updated it to say BookmarkRecyclerView, instead of
BookmarkItemsContainer.

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkModel.java:145:
* Add an observer that listens to delete events that go through bookmark model.
On 2016/02/16 22:15:43, Ian Wen wrote:
> the bookmark model?

Done.

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkPage.java:34:
* Create a new instance of an bookmark page.
On 2016/02/16 22:15:43, Ian Wen wrote:
> a bookmark page?

Done.

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkRow.java:110:
R.style.BookmarkMenuStyle);
On 2016/02/16 22:15:43, Ian Wen wrote:
> Can we push #110 to #109 now? 

Done.

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java
(right):

https://codereview.chromium.org/1694093003/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkUtils.java:453:
* Closes the Bookmark Activity on Phone. Does nothing on tablet.
On 2016/02/16 22:15:43, Ian Wen wrote:
> A javadoc link here?

Done.

[newt (away), 2016-02-16 23:51:53]

Thanks for reviewing :)

[newt (away), 2016-02-16 23:52:07]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-02-16 23:52:07]

The patchset sent to the CQ was uploaded after l-g-t-m from ianwen@chromium.org
Link to the patchset: https://codereview.chromium.org/1694093003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-02-16 23:53:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1694093003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1694093003/80001

[commit-bot: I haz the power, 2016-02-17 00:39:58]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-02-17 00:40:49]

Description was changed from

==========
Rename EnhancedBookmarks to Bookmarks, part 2.

There is only one bookmarks UI now, so we can simplify the naming. This
renames resources and strings and updates comments to remove all
remaining references to "enhanced" bookmarks. Primary changes:

 - resource filenames: replace "eb_" prefix with "bookmark_"
 - strings: replace IDS_ENHANCED_BOOKMARK with IDS_BOOKMARK
 - styles: replace "EnhancedBookmark" with "Bookmark"
 - comments: remove "enhanced"

Note: a few references to "enhanced" bookmarks can't be changed: metrics
names, and shared pref names.

BUG=474719
==========

to

==========
Rename EnhancedBookmarks to Bookmarks, part 2.

There is only one bookmarks UI now, so we can simplify the naming. This
renames resources and strings and updates comments to remove all
remaining references to "enhanced" bookmarks. Primary changes:

 - resource filenames: replace "eb_" prefix with "bookmark_"
 - strings: replace IDS_ENHANCED_BOOKMARK with IDS_BOOKMARK
 - styles: replace "EnhancedBookmark" with "Bookmark"
 - comments: remove "enhanced"

Note: a few references to "enhanced" bookmarks can't be changed: metrics
names, and shared pref names.

BUG=474719

Committed: https://crrev.com/f545152772661ba2fc3a6bde9e776f132bad1ada
Cr-Commit-Position: refs/heads/master@{#375726}
==========

[commit-bot: I haz the power, 2016-02-17 00:40:51]

Patchset 5 (id:??) landed as
https://crrev.com/f545152772661ba2fc3a6bde9e776f132bad1ada
Cr-Commit-Position: refs/heads/master@{#375726}