Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: chrome/android/java/src/org/chromium/chrome/browser/bookmarks/BookmarkActivity.java

Issue 1694093003: Rename EnhancedBookmarks to Bookmarks, part 2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package org.chromium.chrome.browser.bookmarks; 5 package org.chromium.chrome.browser.bookmarks;
6 6
7 import android.content.Intent; 7 import android.content.Intent;
8 import android.os.Bundle; 8 import android.os.Bundle;
9 import android.text.TextUtils; 9 import android.text.TextUtils;
10 import android.view.WindowManager; 10 import android.view.WindowManager;
11 11
12 import org.chromium.chrome.R; 12 import org.chromium.chrome.R;
13 import org.chromium.chrome.browser.UrlConstants; 13 import org.chromium.chrome.browser.UrlConstants;
14 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils; 14 import org.chromium.chrome.browser.offlinepages.OfflinePageUtils;
15 import org.chromium.chrome.browser.snackbar.SnackbarManager; 15 import org.chromium.chrome.browser.snackbar.SnackbarManager;
16 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable; 16 import org.chromium.chrome.browser.snackbar.SnackbarManager.SnackbarManageable;
17 import org.chromium.components.bookmarks.BookmarkId; 17 import org.chromium.components.bookmarks.BookmarkId;
18 18
19 /** 19 /**
20 * The activity that displays the bookmark UI on the phone. It keeps a {@link Bo okmarkManager} 20 * The activity that displays the bookmark UI on the phone. It keeps a {@link Bo okmarkManager}
21 * inside of it and creates a snackbar manager. This activity should only be sho wn on phones; on 21 * inside of it and creates a snackbar manager. This activity should only be sho wn on phones; on
22 * tablet the enhanced bookmark UI is shown inside of a tab (see {@link Bookmark Page}). 22 * tablet the bookmark UI is shown inside of a tab (see {@link BookmarkPage}).
23 */ 23 */
24 public class BookmarkActivity extends BookmarkActivityBase implements SnackbarMa nageable { 24 public class BookmarkActivity extends BookmarkActivityBase implements SnackbarMa nageable {
25 25
26 private BookmarkManager mBookmarkManager; 26 private BookmarkManager mBookmarkManager;
27 private SnackbarManager mSnackbarManager; 27 private SnackbarManager mSnackbarManager;
28 static final int EDIT_BOOKMARK_REQUEST_CODE = 14; 28 static final int EDIT_BOOKMARK_REQUEST_CODE = 14;
29 public static final String INTENT_VISIT_BOOKMARK_ID = "BookmarkEditActivity. VisitBookmarkId"; 29 public static final String INTENT_VISIT_BOOKMARK_ID = "BookmarkEditActivity. VisitBookmarkId";
30 30
31 @Override 31 @Override
32 protected void onCreate(Bundle savedInstanceState) { 32 protected void onCreate(Bundle savedInstanceState) {
33 super.onCreate(savedInstanceState); 33 super.onCreate(savedInstanceState);
34 getWindow().clearFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_ BACKGROUNDS); 34 getWindow().clearFlags(WindowManager.LayoutParams.FLAG_DRAWS_SYSTEM_BAR_ BACKGROUNDS);
35 mSnackbarManager = new SnackbarManager(getWindow()); 35 mSnackbarManager = new SnackbarManager(getWindow());
36 mBookmarkManager = new BookmarkManager(this, true); 36 mBookmarkManager = new BookmarkManager(this, true);
37 String url = getIntent().getDataString(); 37 String url = getIntent().getDataString();
38 if (TextUtils.isEmpty(url)) url = UrlConstants.BOOKMARKS_URL; 38 if (TextUtils.isEmpty(url)) url = UrlConstants.BOOKMARKS_URL;
39 mBookmarkManager.updateForUrl(url); 39 mBookmarkManager.updateForUrl(url);
40 40
41 setContentView(mBookmarkManager.getView()); 41 setContentView(mBookmarkManager.getView());
42 BookmarkUtils.setTaskDescriptionInDocumentMode( 42 BookmarkUtils.setTaskDescriptionInDocumentMode(
43 this, getString(OfflinePageUtils.getStringId(R.string.bookmarks) )); 43 this, getString(OfflinePageUtils.getStringId(R.string.bookmarks) ));
44 44
45 // Hack to work around inferred theme false lint error: http://crbug.com /445633 45 // Hack to work around inferred theme false lint error: http://crbug.com /445633
46 assert (R.layout.eb_main_content != 0); 46 assert (R.layout.bookmark_main_content != 0);
47 } 47 }
48 48
49 @Override 49 @Override
50 protected void onStart() { 50 protected void onStart() {
51 super.onStart(); 51 super.onStart();
52 mSnackbarManager.onStart(); 52 mSnackbarManager.onStart();
53 } 53 }
54 54
55 @Override 55 @Override
56 protected void onStop() { 56 protected void onStop() {
(...skipping 20 matching lines...) Expand all
77 @Override 77 @Override
78 protected void onActivityResult(int requestCode, int resultCode, Intent data ) { 78 protected void onActivityResult(int requestCode, int resultCode, Intent data ) {
79 super.onActivityResult(requestCode, resultCode, data); 79 super.onActivityResult(requestCode, resultCode, data);
80 if (requestCode == EDIT_BOOKMARK_REQUEST_CODE && resultCode == RESULT_OK ) { 80 if (requestCode == EDIT_BOOKMARK_REQUEST_CODE && resultCode == RESULT_OK ) {
81 BookmarkId bookmarkId = BookmarkId.getBookmarkIdFromString(data.getS tringExtra( 81 BookmarkId bookmarkId = BookmarkId.getBookmarkIdFromString(data.getS tringExtra(
82 INTENT_VISIT_BOOKMARK_ID)); 82 INTENT_VISIT_BOOKMARK_ID));
83 mBookmarkManager.openBookmark(bookmarkId, BookmarkLaunchLocation.BOO KMARK_EDITOR); 83 mBookmarkManager.openBookmark(bookmarkId, BookmarkLaunchLocation.BOO KMARK_EDITOR);
84 } 84 }
85 } 85 }
86 } 86 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698