components/content_settings/core/browser/cookie_settings.cc - Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/browser/cookie_settings.cc

Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: Add SetCookieException to handle custom patterns Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/content_settings/core/browser/cookie_settings.h ('k') | components/content_settings/core/browser/cookie_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/content_settings/core/browser/cookie_settings.cc

diff --git a/components/content_settings/core/browser/cookie_settings.cc b/components/content_settings/core/browser/cookie_settings.cc

index 2339c86cddd95e1b8fb4ddcb39456082a69b8776..9d8a7e54be629c57e497b1e2c5ed5ffdb3b4559c 100644

--- a/components/content_settings/core/browser/cookie_settings.cc

+++ b/components/content_settings/core/browser/cookie_settings.cc

@@ -92,7 +92,15 @@ void CookieSettings::SetDefaultCookieSetting(ContentSetting setting) {

CONTENT_SETTINGS_TYPE_COOKIES, setting);

}

-void CookieSettings::SetCookieSetting(

+void CookieSettings::SetCookieSetting(const GURL& primary_url,

+ ContentSetting setting) {

+ DCHECK(IsValidSetting(setting));

+ host_content_settings_map_->SetContentSettingDefaultScope(

+ primary_url, GURL(), CONTENT_SETTINGS_TYPE_COOKIES, std::string(),

+ setting);

+void CookieSettings::SetCookieException(

const ContentSettingsPattern& primary_pattern,

const ContentSettingsPattern& secondary_pattern,

ContentSetting setting) {