Use GURLS instead of patterns in SetCookieSetting()

components/content_settings/core/browser/cookie_settings.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/content_settings/core/browser/cookie_settings.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "components/content_settings/core/browser/content_settings_utils.h"
 #include "components/content_settings/core/browser/host_content_settings_map.h"
@@ skipping 74 matching lines @@
       prefs::kBlockThirdPartyCookies, false,
       user_prefs::PrefRegistrySyncable::SYNCABLE_PREF);
 }
 
 void CookieSettings::SetDefaultCookieSetting(ContentSetting setting) {
   DCHECK(IsValidSetting(setting));
   host_content_settings_map_->SetDefaultContentSetting(
       CONTENT_SETTINGS_TYPE_COOKIES, setting);
 }
 
-void CookieSettings::SetCookieSetting(
+void CookieSettings::SetCookieSetting(const GURL& primary_url,
+                                      ContentSetting setting) {
+  DCHECK(IsValidSetting(setting));
+  host_content_settings_map_->SetContentSettingDefaultScope(
+      primary_url, GURL(), CONTENT_SETTINGS_TYPE_COOKIES, std::string(),
+      setting);
+}
+
+void CookieSettings::SetCookieException(
     const ContentSettingsPattern& primary_pattern,
     const ContentSettingsPattern& secondary_pattern,
     ContentSetting setting) {
   DCHECK(IsValidSetting(setting));
   if (setting == CONTENT_SETTING_SESSION_ONLY) {
     DCHECK(secondary_pattern == ContentSettingsPattern::Wildcard());

[raymes, 2016/03/17 04:21:29]

DCHECK_EQ(..., ...);

[lshang, 2016/03/17 08:49:53]

Didn't address this. DCHECK_EQ can only compare two values. 

   }

[raymes, 2016/03/17 04:21:29]

nit: no {}

[lshang, 2016/03/17 08:49:53]

Done.

   host_content_settings_map_->SetContentSetting(
       primary_pattern, secondary_pattern, CONTENT_SETTINGS_TYPE_COOKIES,
       std::string(), setting);
 }
 
 void CookieSettings::ResetCookieSetting(
     const ContentSettingsPattern& primary_pattern,
     const ContentSettingsPattern& secondary_pattern) {
   host_content_settings_map_->SetContentSetting(
       primary_pattern, secondary_pattern, CONTENT_SETTINGS_TYPE_COOKIES,
@@ skipping 71 matching lines @@
   block_third_party_cookies_ = pref_change_registrar_.prefs()->GetBoolean(
       prefs::kBlockThirdPartyCookies);
 }
 
 bool CookieSettings::ShouldBlockThirdPartyCookies() const {
   base::AutoLock auto_lock(lock_);
   return block_third_party_cookies_;
 }
 
 }  // namespace content_settings