chrome/browser/extensions/extension_special_storage_policy_unittest.cc - Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

Issue 1694063002: Use GURLS instead of patterns in SetCookieSetting() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@scoping_set_content_setting

Patch Set: Add SetCookieException to handle custom patterns Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/cookie_settings_factory_unittest.cc ('k') | chrome/browser/net/chrome_network_delegate_unittest.cc » ('j') | components/content_settings/core/browser/cookie_settings.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_special_storage_policy_unittest.cc

diff --git a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

index c69b1822584ab8304e542803d868aa444edb412b..46309c72362c0f4d28446c9950a320b567cd2a49 100644

--- a/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

+++ b/chrome/browser/extensions/extension_special_storage_policy_unittest.cc

@@ -331,12 +331,12 @@ TEST_F(ExtensionSpecialStoragePolicyTest, HasSessionOnlyOrigins) {

EXPECT_FALSE(policy_->HasSessionOnlyOrigins());

// Or the session-onlyness can affect individual origins.

+ // TODO(lshang): Remove the pattern after ResetCookieSetting() is also changed

+ // to use GURL.

ContentSettingsPattern pattern =

- ContentSettingsPattern::FromString("pattern.com");

- cookie_settings->SetCookieSetting(pattern,

- ContentSettingsPattern::Wildcard(),

- CONTENT_SETTING_SESSION_ONLY);

+ ContentSettingsPattern::FromString("[*.]pattern.com");

+ GURL url("http://pattern.com");

+ cookie_settings->SetCookieSetting(url, CONTENT_SETTING_SESSION_ONLY);

EXPECT_TRUE(policy_->HasSessionOnlyOrigins());