Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1694023002: Revert of Fix colorType/alphaType checks in SkCodec (Closed)

Created:
4 years, 10 months ago by msarett
Modified:
4 years, 10 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Fix colorType/alphaType checks in SkCodec (patchset #5 id:80001 of https://codereview.chromium.org/1695473002/ ) Reason for revert: Really bad images in Gold. Original issue's description: > Fix colorType/alphaType checks in SkCodec > > Make getPixels() and startScanlineDecode() behave > consistently. > > Require that kGray8 decodes are opaque. > > Assert that creating the swizzler succeeds. > > BUG=skia:4203 > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1695473002 > > Committed: https://skia.googlesource.com/skia/+/c7578b6cdd03b61f076ffc7956efd952d6c301c0 TBR=scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:4203 Committed: https://skia.googlesource.com/skia/+/deabdb5b9712de9e3c6bbb9aa68ec2f20df80a8e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -43 lines) Patch
M src/codec/SkBmpMaskCodec.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkBmpMaskCodec.cpp View 1 chunk +17 lines, -4 lines 0 comments Download
M src/codec/SkBmpStandardCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkBmpStandardCodec.cpp View 4 chunks +13 lines, -5 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
M src/codec/SkCodecPriv.h View 1 chunk +1 line, -6 lines 0 comments Download
M src/codec/SkGifCodec.h View 1 chunk +1 line, -1 line 0 comments Download
M src/codec/SkGifCodec.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/codec/SkWbmpCodec.cpp View 6 chunks +18 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Fix colorType/alphaType checks in SkCodec
4 years, 10 months ago (2016-02-12 22:59:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1694023002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1694023002/1
4 years, 10 months ago (2016-02-12 23:00:04 UTC) #2
commit-bot: I haz the power
4 years, 10 months ago (2016-02-12 23:00:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/deabdb5b9712de9e3c6bbb9aa68ec2f20df80a8e

Powered by Google App Engine
This is Rietveld 408576698