Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/codec/SkBmpMaskCodec.cpp

Issue 1694023002: Revert of Fix colorType/alphaType checks in SkCodec (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/codec/SkBmpMaskCodec.h ('k') | src/codec/SkBmpStandardCodec.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2015 Google Inc. 2 * Copyright 2015 Google Inc.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license that can be 4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file. 5 * found in the LICENSE file.
6 */ 6 */
7 7
8 #include "SkBmpMaskCodec.h" 8 #include "SkBmpMaskCodec.h"
9 #include "SkCodecPriv.h" 9 #include "SkCodecPriv.h"
10 #include "SkColorPriv.h" 10 #include "SkColorPriv.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 } 51 }
52 52
53 int rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts); 53 int rows = this->decodeRows(dstInfo, dst, dstRowBytes, opts);
54 if (rows != dstInfo.height()) { 54 if (rows != dstInfo.height()) {
55 *rowsDecoded = rows; 55 *rowsDecoded = rows;
56 return kIncompleteInput; 56 return kIncompleteInput;
57 } 57 }
58 return kSuccess; 58 return kSuccess;
59 } 59 }
60 60
61 bool SkBmpMaskCodec::initializeSwizzler(const SkImageInfo& dstInfo, const Option s& options) {
62 // Create the swizzler
63 fMaskSwizzler.reset(SkMaskSwizzler::CreateMaskSwizzler(dstInfo, this->getInf o(), fMasks,
64 this->bitsPerPixel(), options));
65
66 if (nullptr == fMaskSwizzler.get()) {
67 return false;
68 }
69
70 return true;
71 }
72
61 SkCodec::Result SkBmpMaskCodec::prepareToDecode(const SkImageInfo& dstInfo, 73 SkCodec::Result SkBmpMaskCodec::prepareToDecode(const SkImageInfo& dstInfo,
62 const SkCodec::Options& options, SkPMColor inputColorPtr[], int* inputCo lorCount) { 74 const SkCodec::Options& options, SkPMColor inputColorPtr[], int* inputCo lorCount) {
63 // Initialize the mask swizzler 75 // Initialize a the mask swizzler
64 fMaskSwizzler.reset(SkMaskSwizzler::CreateMaskSwizzler(dstInfo, this->getInf o(), fMasks, 76 if (!this->initializeSwizzler(dstInfo, options)) {
65 this->bitsPerPixel(), options)); 77 SkCodecPrintf("Error: cannot initialize swizzler.\n");
66 SkASSERT(fMaskSwizzler); 78 return SkCodec::kInvalidConversion;
79 }
67 80
68 return SkCodec::kSuccess; 81 return SkCodec::kSuccess;
69 } 82 }
70 83
71 /* 84 /*
72 * Performs the decoding 85 * Performs the decoding
73 */ 86 */
74 int SkBmpMaskCodec::decodeRows(const SkImageInfo& dstInfo, 87 int SkBmpMaskCodec::decodeRows(const SkImageInfo& dstInfo,
75 void* dst, size_t dstRowBytes, 88 void* dst, size_t dstRowBytes,
76 const Options& opts) { 89 const Options& opts) {
77 // Iterate over rows of the image 90 // Iterate over rows of the image
78 uint8_t* srcRow = fSrcBuffer.get(); 91 uint8_t* srcRow = fSrcBuffer.get();
79 const int height = dstInfo.height(); 92 const int height = dstInfo.height();
80 for (int y = 0; y < height; y++) { 93 for (int y = 0; y < height; y++) {
81 // Read a row of the input 94 // Read a row of the input
82 if (this->stream()->read(srcRow, fSrcRowBytes) != fSrcRowBytes) { 95 if (this->stream()->read(srcRow, fSrcRowBytes) != fSrcRowBytes) {
83 SkCodecPrintf("Warning: incomplete input stream.\n"); 96 SkCodecPrintf("Warning: incomplete input stream.\n");
84 return y; 97 return y;
85 } 98 }
86 99
87 // Decode the row in destination format 100 // Decode the row in destination format
88 uint32_t row = this->getDstRow(y, height); 101 uint32_t row = this->getDstRow(y, height);
89 void* dstRow = SkTAddOffset<void>(dst, row * dstRowBytes); 102 void* dstRow = SkTAddOffset<void>(dst, row * dstRowBytes);
90 fMaskSwizzler->swizzle(dstRow, srcRow); 103 fMaskSwizzler->swizzle(dstRow, srcRow);
91 } 104 }
92 105
93 // Finished decoding the entire image 106 // Finished decoding the entire image
94 return height; 107 return height;
95 } 108 }
OLDNEW
« no previous file with comments | « src/codec/SkBmpMaskCodec.h ('k') | src/codec/SkBmpStandardCodec.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698